public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102880] [12 Regression] Dead Code Elimination Regression at -O3
Date: Tue, 16 Nov 2021 10:32:15 +0000	[thread overview]
Message-ID: <bug-102880-4-3tvaMYERrs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102880-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102880

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:045206450386bcd774db3bde0c696828402361c6

commit r12-5301-g045206450386bcd774db3bde0c696828402361c6
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Nov 12 10:21:22 2021 +0100

    tree-optimization/102880 - improve CD-DCE

    The PR shows a missed control-dependent DCE caused by CFG cleanup
    merging a forwarder resulting in a partially degenerate PHI node.
    With control-dependent DCE we need to mark control dependences
    of incoming edges into PHIs as necessary but that is unnecessarily
    conservative for the case when two edges have the same value.
    There is no easy way to mark only a subset of control dependences
    of both edges necessary so the fix is to produce forwarder blocks
    where then the control dependence captures the requirements more
    precisely.

    For gcc.dg/tree-ssa/ssa-dom-thread-7.c the number of edges in the
    CFG decrease as we have commonized PHI arguments which in turn
    results in different threadings.  The testcase is too complex
    and the dump scanning too simple to do anything meaningful here
    but to adjust the number of expected threads.

    The same CFG massaging could be useful at RTL expansion time to
    reduce the number of copies we need to insert on edges.

    FAIL: gcc.dg/tree-ssa/ssa-hoist-4.c scan-tree-dump-times optimized
"MAX_EXPR" 1

    2021-11-12  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/102880
            * tree-ssa-dce.c (sort_phi_args): New function.
            (make_forwarders_with_degenerate_phis): Likewise.
            (perform_tree_ssa_dce): Call
            make_forwarders_with_degenerate_phis.

            * gcc.dg/tree-ssa/pr102880.c: New testcase.
            * gcc.dg/tree-ssa/pr69270-3.c: Robustify.
            * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Change the number of
            expected threadings.

  parent reply	other threads:[~2021-11-16 10:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 13:27 [Bug tree-optimization/102880] New: " theodort at inf dot ethz.ch
2021-10-21 13:46 ` [Bug tree-optimization/102880] " marxin at gcc dot gnu.org
2021-10-22  6:56 ` pinskia at gcc dot gnu.org
2021-10-22  6:57 ` rguenth at gcc dot gnu.org
2021-10-22  8:44 ` rguenth at gcc dot gnu.org
2021-10-29  9:09 ` rguenth at gcc dot gnu.org
2021-11-11 12:42 ` rguenth at gcc dot gnu.org
2021-11-16 10:31 ` cvs-commit at gcc dot gnu.org
2021-11-16 10:32 ` cvs-commit at gcc dot gnu.org [this message]
2021-11-16 10:33 ` rguenth at gcc dot gnu.org
2021-11-17  8:41 ` clyon at gcc dot gnu.org
2021-11-17  8:47 ` pinskia at gcc dot gnu.org
2021-11-18  8:56 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102880-4-3tvaMYERrs@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).