From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8DE7C3858004; Tue, 16 Nov 2021 10:31:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DE7C3858004
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102880] [12 Regression] Dead Code Elimination
 Regression at -O3
Date: Tue, 16 Nov 2021 10:31:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-102880-4-r0IK4pyxUg@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102880-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102880-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Nov 2021 10:31:18 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102880

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:f98f373dd822b35c52356b753d528924e9f89678

commit r12-5300-gf98f373dd822b35c52356b753d528924e9f89678
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Nov 15 15:19:36 2021 +0100

    tree-optimization/102880 - make PHI-OPT recognize more CFGs

    This allows extra edges into the middle BB for the PHI-OPT
    transforms using replace_phi_edge_with_variable that do not
    end up moving stmts from that middle BB.  This avoids regressing
    gcc.dg/tree-ssa/ssa-hoist-4.c with the actual fix for PR102880
    where CFG cleanup has the choice to remove two forwarders and
    picks "the wrong" leading to

       if (a > b) /
           /\    /
          /  <BB>
         /    |
      # PHI <a, b>

    rather than

       if (a > b)  |
           /\      |
        <BB> \     |
         /    \    |
      # PHI <a, b, b>

    but it's relatively straight-forward to support extra edges
    into the middle-BB in paths ending in replace_phi_edge_with_variable
    and that do not require moving stmts.  That's because we really
    only want to remove the edge from the condition to the middle BB.
    Of course actually doing that means updating dominators in non-trival
    ways which is why I kept the original code for the single edge
    case and simply defer to CFG cleanup by adjusting the condition for
    the complicated case.

    The testcase needs to be a GIMPLE one since it's quite unreliable
    to produce the desired CFG.

    2021-11-15  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/102880
            * tree-ssa-phiopt.c (tree_ssa_phiopt_worker): Push
            single_pred (bb1) condition to places that really need it.
            (match_simplify_replacement): Likewise.
            (value_replacement): Likewise.
            (replace_phi_edge_with_variable): Deal with extra edges
            into the middle BB.

            * gcc.dg/tree-ssa/phi-opt-26.c: New testcase.=