public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102902] [12 Regression] -O3 produces code that uses an uninitialized variable but originally was not used by r12-3876
Date: Mon, 25 Oct 2021 08:45:18 +0000	[thread overview]
Message-ID: <bug-102902-4-pZjlD2M4pf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102902-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102902

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
I guess fixed with:

commit aa15952d646fd5dd569fce287b719a737ae66e4f (HEAD -> master, origin/trunk,
origin/master, origin/HEAD)
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Oct 25 09:33:15 2021 +0200

    tree-optimization/102920 - fix PHI VN with undefined args

    This fixes a latent issue exposed by now allowing VN_TOP in PHI
    arguments.  We may only use optimistic equality when merging values on
    different edges, not when merging values on the same edge - in particular
    we may not choose the undef value on any edge when there's a not undef
    value as well.

    2021-10-25  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/102920
            * tree-ssa-sccvn.h (expressions_equal_p): Add argument
            controlling VN_TOP matching behavior.
            * tree-ssa-sccvn.c (expressions_equal_p): Likewise.
            (vn_phi_eq): Do not optimistically match VN_TOP.

            * gcc.dg/torture/pr102920.c: New testcase.

  parent reply	other threads:[~2021-10-25  8:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 17:35 [Bug tree-optimization/102902] New: wrong code at -O3 on x86_64-linux-gnu (generated code hangs) zhendong.su at inf dot ethz.ch
2021-10-22 18:53 ` [Bug tree-optimization/102902] [12 Regression] " pinskia at gcc dot gnu.org
2021-10-22 21:20 ` pinskia at gcc dot gnu.org
2021-10-25  8:44 ` [Bug tree-optimization/102902] [12 Regression] -O3 produces code that uses an uninitialized variable but originally was not used by r12-3876 marxin at gcc dot gnu.org
2021-10-25  8:45 ` marxin at gcc dot gnu.org [this message]
2021-10-25  8:57 ` marxin at gcc dot gnu.org
2021-10-25  8:58 ` rguenth at gcc dot gnu.org
2021-11-24  8:35 ` zhendong.su at inf dot ethz.ch
2021-11-24  8:44 ` pinskia at gcc dot gnu.org
2021-11-24  8:46 ` pinskia at gcc dot gnu.org
2022-01-17 13:09 ` rguenth at gcc dot gnu.org
2022-04-04 12:59 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102902-4-pZjlD2M4pf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).