From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4DE583858402; Mon, 25 Oct 2021 15:50:12 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DE583858402
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libffi/102923] [12 Regression] powerpc64 (BE) linux all
 languages bootstrap broken after libffi 3.4.2 import.
Date: Mon, 25 Oct 2021 15:50:11 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libffi
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: segher at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-102923-4-qDQvY9SdaG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102923-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102923-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Oct 2021 15:50:12 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102923

--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #1)
> The stvx stuff is guarded by #ifdef __VEC__, so perhaps the lvx stuff sho=
uld
> be too, or there should be .machine push; .machine power7; ... .machine p=
op;
> or something similar around it?

Just
        .machine altivec
is enough, no push/pop shenanigans needed.

This can be either inside or outside an #ifdef __VEC__ block, just
personal style preference really :-)

I would put it at the start of the file.

> At least in linux64_closure.S, perhaps guarding it with #ifdef __VEC__ mi=
ght
> be ok, because the C code will not use that code if __VEC__ isn't defined:
> #elif !defined(__VEC__)
>   /* If compiled without vector register support (used by assembly)... */
>   if ((cif->abi & FFI_LINUX_LONG_DOUBLE_IEEE128) !=3D 0)
>     return FFI_BAD_ABI;
> But not sure about linux64.S if it doesn't suffer from the same problem.

Note that __VEC__ does not mean the current CPU can execute those insns,
of course, so these #ifdefs are only good if you compile this file twice,
or similar?=