public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
@ 2021-10-25 18:21 seurer at gcc dot gnu.org
2021-10-26 7:08 ` [Bug testsuite/102935] " rguenth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-10-25 18:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
Bug ID: 102935
Summary: [12 regression] new test case
gcc.target/powerpc/pr101384-1.c fails
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:e0e82856d535f56c916382f892ed2435dde54d4d, r12-2416
make -k check-gcc RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/pr101384-1.c"
FAIL: gcc.target/powerpc/pr101384-1.c scan-assembler-times \\mvspltis[whb]
[^\\n\\r]*,-1\\M 9
# of expected passes 4
# of unexpected failures 1
I only see this on power 9 and power 10.
commit e0e82856d535f56c916382f892ed2435dde54d4d (HEAD, refs/bisect/bad)
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Jul 20 17:26:10 2021 +0200
rs6000: Fix up easy_vector_constant_msb handling [PR101384]
* gcc.target/powerpc/pr101384-1.c: New test.
So, this was a new test in this revision and it apparently has never worked
correctly for power 9/10. I checked and it works ok on power 8.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
@ 2021-10-26 7:08 ` rguenth at gcc dot gnu.org
2022-01-07 23:28 ` meissner at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-10-26 7:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
2021-10-26 7:08 ` [Bug testsuite/102935] " rguenth at gcc dot gnu.org
@ 2022-01-07 23:28 ` meissner at gcc dot gnu.org
2022-01-08 0:36 ` meissner at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: meissner at gcc dot gnu.org @ 2022-01-07 23:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
Michael Meissner <meissner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2022-01-07
CC| |dje at gcc dot gnu.org,
| |meissner at gcc dot gnu.org,
| |segher at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |meissner at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Michael Meissner <meissner at gcc dot gnu.org> ---
The reason it fails on power9 and power10 is GCC uses vspltiw to load up all
1's into the vector register. On power9 and power10 it uses xxspltib to load
it up.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
2021-10-26 7:08 ` [Bug testsuite/102935] " rguenth at gcc dot gnu.org
2022-01-07 23:28 ` meissner at gcc dot gnu.org
@ 2022-01-08 0:36 ` meissner at gcc dot gnu.org
2022-01-08 0:39 ` meissner at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: meissner at gcc dot gnu.org @ 2022-01-08 0:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
--- Comment #2 from Michael Meissner <meissner at gcc dot gnu.org> ---
Created attachment 52143
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52143&action=edit
Patch to update code generation test
The test wants to load all 1's into a vector register. On power8 it uses
VSPLTIS{B,H,W} to load up the value. On power9 and power10, it uses XXSPLTIB
to load up the value. This patch checks for XXSPLTIB being generated.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2022-01-08 0:36 ` meissner at gcc dot gnu.org
@ 2022-01-08 0:39 ` meissner at gcc dot gnu.org
2022-01-12 16:56 ` cvs-commit at gcc dot gnu.org
2022-01-12 17:02 ` meissner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: meissner at gcc dot gnu.org @ 2022-01-08 0:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
Michael Meissner <meissner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #52143|0 |1
is obsolete| |
--- Comment #3 from Michael Meissner <meissner at gcc dot gnu.org> ---
Created attachment 52144
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52144&action=edit
Patch to fix the code generation test for power9 and power10.
The previous patch posted was the wrong patch.
This patch fixes the regexp in pr101384-1.c to add support for power9 and
power10 using XXSPLTIB to set a vector register to all 1's instead of
VSPLTIS{B,H,W} that power8 generates.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2022-01-08 0:39 ` meissner at gcc dot gnu.org
@ 2022-01-12 16:56 ` cvs-commit at gcc dot gnu.org
2022-01-12 17:02 ` meissner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-12 16:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Michael Meissner <meissner@gcc.gnu.org>:
https://gcc.gnu.org/g:18d88d11973c63bda4e586b979b71d48c1d9b78a
commit r12-6532-g18d88d11973c63bda4e586b979b71d48c1d9b78a
Author: Michael Meissner <meissner@linux.ibm.com>
Date: Wed Jan 12 11:56:22 2022 -0500
Fix pr101384-1.c code generation test.
Add support for the compiler using XXSPLTIB reg,255 to load all 1's into a
register on power9 and above instead of using VSPLTI{B,H,W} reg,-1.
gcc/testsuite/
2022-01-12 Michael Meissner <meissner@the-meissners.org>
PR testsuite/102935
* gcc.target/powerpc/pr101384-1.c: Update insn regexp for power9
and power10.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/102935] [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2022-01-12 16:56 ` cvs-commit at gcc dot gnu.org
@ 2022-01-12 17:02 ` meissner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: meissner at gcc dot gnu.org @ 2022-01-12 17:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102935
Michael Meissner <meissner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from Michael Meissner <meissner at gcc dot gnu.org> ---
Patch committed on January 12th, 2022.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-12 17:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 18:21 [Bug testsuite/102935] New: [12 regression] new test case gcc.target/powerpc/pr101384-1.c fails seurer at gcc dot gnu.org
2021-10-26 7:08 ` [Bug testsuite/102935] " rguenth at gcc dot gnu.org
2022-01-07 23:28 ` meissner at gcc dot gnu.org
2022-01-08 0:36 ` meissner at gcc dot gnu.org
2022-01-08 0:39 ` meissner at gcc dot gnu.org
2022-01-12 16:56 ` cvs-commit at gcc dot gnu.org
2022-01-12 17:02 ` meissner at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).