public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "peterz at infradead dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102953] Improvements to CET-IBT and ENDBR generation
Date: Wed, 27 Oct 2021 08:38:55 +0000	[thread overview]
Message-ID: <bug-102953-4-N9WL1hdzcf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102953-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102953

peterz at infradead dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peterz at infradead dot org

--- Comment #5 from peterz at infradead dot org ---

(In reply to H.J. Lu from comment #1)
> (In reply to Andrew Cooper from comment #0)
> > 
> > Finally, one minor code generation improvement.  When GCC emits a direct
> > call/jmp to an ENDBR'd symbol, it can actually use sym+4 as an optimisation
> > to skip the ENDBR instruction (not needed for direct call/jmp's) and save on
> > decode bandwidth.
> 
> It is only safe for calling a static function whose address has been taken.

Could be done wider using LTO, or pushed into the linker if you're willing to
change the ELF format and augment it with STT_FUNC_BTI and R_*_BTI32, there the
new relocation would mean +4 (or rather, skip landing pad) when aimed at
STT_FUNC_BTI and be identical to _PC32 otherwise.

The ELF thing doesn't help with reducing ENDBR emissions for global symbols
since we can't ever tell who will take the address, but it will help with
directly calling avoiding the landing pad.

It also allows for a 'pseudo' LTO thing to 'seal' an executable, where it will
strip the ENDBRs for all symbols that do not have a _PC32 rela. We can use
EXPORT_SYMBOL*() to generate one such on purpose to avoid exported functions
from being sealed.

Anyway, I think there's much value in reducing the number of ENDBR instructions
as much as possible and we should investigate how the toolchains can best help
there.

  parent reply	other threads:[~2021-10-27  8:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 17:01 [Bug c/102953] New: " andrew.cooper3 at citrix dot com
2021-10-26 20:45 ` [Bug target/102953] " hjl.tools at gmail dot com
2021-10-26 21:31 ` hjl.tools at gmail dot com
2021-10-26 22:48 ` hjl.tools at gmail dot com
2021-10-26 22:49 ` hjl.tools at gmail dot com
2021-10-27  8:38 ` peterz at infradead dot org [this message]
2021-10-27 13:40 ` hjl.tools at gmail dot com
2021-10-27 18:50 ` andrew.cooper3 at citrix dot com
2021-10-27 23:48 ` andrew.cooper3 at citrix dot com
2021-10-28  1:53 ` hjl.tools at gmail dot com
2021-10-28  1:53 ` hjl.tools at gmail dot com
2021-10-28 10:40 ` andrew.cooper3 at citrix dot com
2021-10-28 13:17 ` hjl.tools at gmail dot com
2021-10-28 13:17 ` hjl.tools at gmail dot com
2021-10-28 17:36 ` andrew.cooper3 at citrix dot com
2021-10-28 19:11 ` hjl.tools at gmail dot com
2021-10-28 19:12 ` hjl.tools at gmail dot com
2021-10-29 22:57 ` andrew.cooper3 at citrix dot com
2021-10-30  0:03 ` hjl.tools at gmail dot com
2021-10-30  0:04 ` hjl.tools at gmail dot com
2021-10-30  0:51 ` andrew.cooper3 at citrix dot com
2021-10-30  4:03 ` andrew.cooper3 at citrix dot com
2021-10-30 12:22 ` hjl.tools at gmail dot com
2021-11-05 11:11 ` andrew.cooper3 at citrix dot com
2021-11-05 14:29 ` hjl.tools at gmail dot com
2022-02-23 20:34 ` andrew.cooper3 at citrix dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102953-4-N9WL1hdzcf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).