From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 50CF23858C2B; Thu,  7 Sep 2023 09:21:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50CF23858C2B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1694078484;
	bh=GylTkBLiZe8bX5UlLA1hAGgS02rAyLLSkgzR46jb9UU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Oixm3dvhrZZvFHkjl7XY492xahahOLgxJWBNdaKrFql80gPuwNIOuKnI3hj/pYxjq
	 PR3xRs2G1SOapsoULJ8AWShM6OL3SYVAq3OBJsrOxqx1xNOLwSQXbwV+4fB77oojBd
	 Vg+QdkxYTTa52uojeo8ic2KmvX7OyXya4MMQtF4g=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/102989] Implement C2x's n2763 (_BitInt)
Date: Thu, 07 Sep 2023 09:21:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-102989-4-Uox61wTzN4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102989-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102989-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102989

--- Comment #111 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:18c90eaa25363d34b5bef444fbbad04f5da2522d

commit r14-3774-g18c90eaa25363d34b5bef444fbbad04f5da2522d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Sep 7 11:17:04 2023 +0200

    middle-end: Avoid calling targetm.c.bitint_type_info inside of gcc_asse=
rt
[PR102989]

    On Thu, Sep 07, 2023 at 10:36:02AM +0200, Thomas Schwinge wrote:
    > Minor comment/question: are we doing away with the property that
    > 'assert'-like "calls" must not have side effects?  Per 'gcc/system.h',
    > this is "OK" for 'gcc_assert' for '#if ENABLE_ASSERT_CHECKING' or
    > '#elif (GCC_VERSION >=3D 4005)' -- that is, GCC 4.5, which is always-=
true,
    > thus the "offending" '#else' is never active.  However, it's different
    > for standard 'assert' and 'gcc_checking_assert', so I'm not sure if
    > that's a good property for 'gcc_assert' only?  For example, see also
    > <https://gcc.gnu.org/PR6906> "warn about asserts with side effects", =
or
    > recent <https://gcc.gnu.org/PR111144>
    > "RFE: could -fanalyzer warn about assertions that have side effects?".

    You're right, the
      #define gcc_assert(EXPR) ((void)(0 && (EXPR)))
    fallback definition is incompatible with the way I've used it, so for
    --disable-checking built by non-GCC it would not work properly.

    2023-09-07  Jakub Jelinek  <jakub@redhat.com>

            PR c/102989
            * expr.cc (expand_expr_real_1): Don't call
targetm.c.bitint_type_info
            inside gcc_assert, as later code relies on it filling info
variable.
            * gimple-fold.cc (clear_padding_bitint_needs_padding_p,
            clear_padding_type): Likewise.
            * varasm.cc (output_constant): Likewise.
            * fold-const.cc (native_encode_int, native_interpret_int):
Likewise.
            * stor-layout.cc (finish_bitfield_representative, layout_type):
            Likewise.
            * gimple-lower-bitint.cc (bitint_precision_kind): Likewise.=