From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D82153858D39; Wed,  1 Nov 2023 08:18:15 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D82153858D39
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1698826695;
	bh=G2ItekeDh3d7+x5IEr4EzKOTB+PVOio+X90GKTJJJnU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=hlg8zx+L3yJwX4s77gAZlyve7PHvF6ynb3F0T5fsnc6z6jieAewWncF6M3N2IvPhp
	 NHSVDZEQ8g5EVbBsw38XUnII5fdM4kPBKimrLYSrc7lrg+xLaluNrHxmh0nhAlNgYk
	 XpOjbJSI92YV8n+UulxPLMKFZH/wDxUlV3LbiorM=
From: "gaius at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/102989] Implement C2x's n2763 (_BitInt)
Date: Wed, 01 Nov 2023 08:17:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: gaius at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-102989-4-kktFYgRM5v@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102989-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102989-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102989

--- Comment #115 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 56482
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D56482&action=3Dedit
modula2: proposed fix to fix largeconst.mod

Here is a patch set for the modula2 fe which re-implements the ZTYPE overfl=
ow
detection.

Bootstrapped on x86_64 all regressions pass.

The ZTYPE in iso modula2 is used to denote intemediate ordinal type const
expressions and these are always converted into the
approriate language or user ordinal type prior to code generation.
The increase of bits supported by _BitInt causes the modula2 largeconst.mod
regression failure tests to pass.  The largeconst.mod test has been
increased to fail, however the char at a time overflow check is now too slow
to detect failure.  The overflow detection for the ZTYPE has been
rewritten to check against exceeding WIDE_INT_MAX_PRECISION (many orders of
magnitude faster).

gcc/m2/ChangeLog:

        * gm2-compiler/SymbolTable.mod (OverflowZType): Import from m2expr.
        (ConstantStringExceedsZType): Remove import.
        (GetConstLitType): Replace ConstantStringExceedsZType with
OverflowZType.
        * gm2-gcc/m2decl.cc (m2decl_ConstantStringExceedsZType): Remove.
        (m2decl_BuildConstLiteralNumber): Re-write.
        * gm2-gcc/m2decl.def (ConstantStringExceedsZType): Remove.
        * gm2-gcc/m2decl.h (m2decl_ConstantStringExceedsZType): Remove.
        * gm2-gcc/m2expr.cc (m2expr_StrToWideInt): Rewrite to check overflo=
w.
        (m2expr_OverflowZType): New function.
        (ToWideInt): New function.
        * gm2-gcc/m2expr.def (OverflowZType): New procedure function
declaration.
        * gm2-gcc/m2expr.h (m2expr_OverflowZType): New prototype.

gcc/testsuite/ChangeLog:

        * gm2/pim/fail/largeconst.mod: Updated foo to an outrageous value.
        * gm2/pim/fail/largeconst2.mod: Duplicate test removed.=