public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fx at gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103008] New: poor inlined builtin_fmod on x86_64
Date: Sat, 30 Oct 2021 18:51:33 +0000	[thread overview]
Message-ID: <bug-103008-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103008

            Bug ID: 103008
           Summary: poor inlined builtin_fmod on x86_64
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fx at gnu dot org
  Target Milestone: ---
            Target: x86_64

Created attachment 51706
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51706&action=edit
ggl.f90

This is from looking at a Fortran benchmark set
<https://www.fortran.uk/fortran-compiler-comparisons/>, but presumably
isn't Fortran-specific.

One of the cases in that set (ac.f90) gets bottlenecked on a random
number routine (which may be rubbish, but it's there).  It uses DMOD,
which gets compiled to __builtin_fmod according to the tree dump, and
is inlined.  However, the benchmark performance is still 50% worse
with gfortran than Intel ifort, and if I replace DMOD with its
definition, gfortran is much closer to ifort.

I'll attach files ggl.f90, the original, and gglx.f90 which avoids the
call to the intrinsic, along with assembler from each.  The assembler
is from GCC 11.2.0, run (on SKX) as

  gfortran -Ofast -march=native

(I note that the generated fmod isn't inlined with -O3, which looks to
me like a Fortran miss that I should report.)

I only take benchmarks too seriously for understanding the results
but, at least with PDO, GCC is pretty much on a par with ifort on the
bottom line of that set, despite also #40770, and another poor case. :-)

             reply	other threads:[~2021-10-30 18:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 18:51 fx at gnu dot org [this message]
2021-10-30 18:52 ` [Bug target/103008] " fx at gnu dot org
2021-10-30 18:55 ` fx at gnu dot org
2021-10-30 18:56 ` fx at gnu dot org
2021-10-30 20:15 ` fx at gnu dot org
2021-10-30 20:39 ` anlauf at gcc dot gnu.org
2021-10-31 20:05 ` ubizjak at gmail dot com
2021-11-01  8:23 ` ubizjak at gmail dot com
2022-02-10 14:18 ` rguenth at gcc dot gnu.org
2022-02-10 14:22 ` rguenth at gcc dot gnu.org
2022-02-10 18:09 ` ubizjak at gmail dot com
2022-02-10 20:50 ` joseph at codesourcery dot com
2022-02-11  7:59 ` rguenth at gcc dot gnu.org
2022-02-11 15:47 ` ubizjak at gmail dot com
2022-02-12 22:07 ` ubizjak at gmail dot com
2022-02-13 21:00 ` Dave.Love at manchester dot ac.uk
2022-02-14  7:12 ` rguenther at suse dot de
2022-02-14  7:35 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103008-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).