public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/103032] false positive diagnostic from -fanalyzer about double-free
Date: Tue, 16 Nov 2021 23:23:36 +0000	[thread overview]
Message-ID: <bug-103032-4-GHWDumQsus@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103032-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103032

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
I haven't yet reproduced the precise symptoms you reported, but FWIW I'm seeing
this in got_gsd, which looks like a true warning for this code:

           | 1903 |             psects[psectid] = strdup(name);
           |      |                               ~~~~~~~~~~~~
           |      |                               |
           |      |                               (43) this call could return
NULL
           | 1904 |             trim(psects[psectid++]);
           |      |             ~~~~~~~~~~~~~~~~~~~~~~~
           |      |             |
           |      |             (44) calling ‘trim’ from ‘got_gsd’
           |
           +--> ‘trim’: events 45-46
                  |
                  | 1800 | void trim(
                  |      |      ^~~~
                  |      |      |
                  |      |      (45) entry to ‘trim’
                  |......
                  | 1805 |     for (cp = buf + strlen(buf); cp > buf; cp--)
                  |      |                     ~~~~~~~~~~~
                  |      |                     |
                  |      |                     (46) argument 1 (‘buf’) from
(43) could be NULL where non-null expected
                  |
../../src/gcc/testsuite/gcc.dg/analyzer/pr103032.c:1173:8: note: argument 1 of
‘strlen’ must be non-null
 1173 | size_t strlen(const char *);
      |        ^~~~~~

  reply	other threads:[~2021-11-16 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 21:22 [Bug analyzer/103032] New: " rhialto at falu dot nl
2021-11-16 23:23 ` dmalcolm at gcc dot gnu.org [this message]
2021-11-17 21:13 ` [Bug analyzer/103032] " rhialto at falu dot nl
2021-11-18 15:52 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103032-4-GHWDumQsus@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).