* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
@ 2021-11-03 8:26 ` rguenth at gcc dot gnu.org
2021-11-03 8:45 ` marxin at gcc dot gnu.org
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-11-03 8:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
2021-11-03 8:26 ` [Bug testsuite/103051] " rguenth at gcc dot gnu.org
@ 2021-11-03 8:45 ` marxin at gcc dot gnu.org
2021-11-03 8:45 ` marxin at gcc dot gnu.org
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-03 8:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Mine.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
2021-11-03 8:26 ` [Bug testsuite/103051] " rguenth at gcc dot gnu.org
2021-11-03 8:45 ` marxin at gcc dot gnu.org
@ 2021-11-03 8:45 ` marxin at gcc dot gnu.org
2021-11-03 9:44 ` marxin at gcc dot gnu.org
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-03 8:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
Ever confirmed|0 |1
Last reconfirmed| |2021-11-03
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |marxin at gcc dot gnu.org
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2021-11-03 8:45 ` marxin at gcc dot gnu.org
@ 2021-11-03 9:44 ` marxin at gcc dot gnu.org
2021-11-03 14:23 ` seurer at gcc dot gnu.org
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-03 9:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I've just used gcc110.fsffrance.org machine (Power 7 machine) and I see the
following TSVC failures:
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s112.c -flto -ffat-lto-objects
scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s315.c scan-tree-dump-times vect "vectorized 1
loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s3251.c -flto -ffat-lto-objects
scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s2244.c scan-tree-dump-times vect "vectorized
1 loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s315.c -flto -ffat-lto-objects
scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s3251.c scan-tree-dump-times vect "vectorized
1 loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s112.c scan-tree-dump-times vect "vectorized 1
loops" 1
FAIL: gcc.dg/vect/tsvc/vect-tsvc-s2244.c -flto -ffat-lto-objects
scan-tree-dump-times vect "vectorized 1 loops" 1
What skip-if filter do you suggest Seurer? Btw. there are quite some other
vect.exp tests failing on the machine.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2021-11-03 9:44 ` marxin at gcc dot gnu.org
@ 2021-11-03 14:23 ` seurer at gcc dot gnu.org
2021-11-04 10:37 ` marxin at gcc dot gnu.org
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-11-03 14:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #3 from seurer at gcc dot gnu.org ---
vect_hw_misalign is one way though it is used in the dg-final instead of
dg-skip. There are lots of examples in other vect tests.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2021-11-03 14:23 ` seurer at gcc dot gnu.org
@ 2021-11-04 10:37 ` marxin at gcc dot gnu.org
2021-11-10 13:40 ` marxin at gcc dot gnu.org
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-04 10:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
All right, so I would ideally use:
/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target {
has_arch_pwr7 } } } } */
but I see the following problem with detection of the target:
78 Executing on host: /dev/shm/objdir/gcc/xgcc -B/dev/shm/objdir/gcc/
arch_pwr759296.c -fdiagnostics-plain-output -S -o arch_pwr759296.s
(timeout = 300)
79 spawn -ignore SIGHUP /dev/shm/objdir/gcc/xgcc -B/dev/shm/objdir/gcc/
arch_pwr759296.c -fdiagnostics-plain-output -S -o arch_pwr759296.s^M
80 arch_pwr759296.c:3:18: error: #error does not have power7 support.^M
81 compiler exited with status 1
82 output is:
83 arch_pwr759296.c:3:18: error: #error does not have power7 support.^M
Note the
#ifndef _ARCH_PWR7
only works when one uses -mcpu=native (or a corresponding -mflag), am I right?
Shouldn't the function check_effective_target_has_arch_pwr7 pass -mcpu=native?
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2021-11-04 10:37 ` marxin at gcc dot gnu.org
@ 2021-11-10 13:40 ` marxin at gcc dot gnu.org
2021-11-10 14:56 ` willschm at gcc dot gnu.org
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-10 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |willschm at gcc dot gnu.org
--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
> Note the
>
> #ifndef _ARCH_PWR7
>
> only works when one uses -mcpu=native (or a corresponding -mflag), am I
> right?
> Shouldn't the function check_effective_target_has_arch_pwr7 pass
> -mcpu=native?
@Bill, @Will: ?
Apparently, the code was introduced by Will.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (6 preceding siblings ...)
2021-11-10 13:40 ` marxin at gcc dot gnu.org
@ 2021-11-10 14:56 ` willschm at gcc dot gnu.org
2021-11-10 16:31 ` segher at gcc dot gnu.org
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: willschm at gcc dot gnu.org @ 2021-11-10 14:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
Will Schmidt <willschm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |segher at gcc dot gnu.org,
| |wschmidt at gcc dot gnu.org
--- Comment #6 from Will Schmidt <willschm at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #4)
> All right, so I would ideally use:
>
> /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target
> { has_arch_pwr7 } } } } */
>
> but I see the following problem with detection of the target:
>
> 78 Executing on host: /dev/shm/objdir/gcc/xgcc -B/dev/shm/objdir/gcc/
> arch_pwr759296.c -fdiagnostics-plain-output -S -o arch_pwr759296.s
> (timeout = 300)
> 79 spawn -ignore SIGHUP /dev/shm/objdir/gcc/xgcc -B/dev/shm/objdir/gcc/
> arch_pwr759296.c -fdiagnostics-plain-output -S -o arch_pwr759296.s^M
> 80 arch_pwr759296.c:3:18: error: #error does not have power7 support.^M
>
> 81 compiler exited with status 1
>
> 82 output is:
>
> 83 arch_pwr759296.c:3:18: error: #error does not have power7 support.^M
>
>
> Note the
>
> #ifndef _ARCH_PWR7
>
> only works when one uses -mcpu=native (or a corresponding -mflag), am I
> right?
> Shouldn't the function check_effective_target_has_arch_pwr7 pass
> -mcpu=native?
I would expect it to pass with -mcpu=native.
Needs a closer look, not sure if I can get to it in short order. Added Bill
and Segher to cc.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (7 preceding siblings ...)
2021-11-10 14:56 ` willschm at gcc dot gnu.org
@ 2021-11-10 16:31 ` segher at gcc dot gnu.org
2021-11-10 16:38 ` segher at gcc dot gnu.org
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: segher at gcc dot gnu.org @ 2021-11-10 16:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #7 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #4)
> Shouldn't the function check_effective_target_has_arch_pwr7 pass
> -mcpu=native?
No. It checks if the effective target (set by options elsewhere!) is
power7 (or up). It does not test a feature of the hardware.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (8 preceding siblings ...)
2021-11-10 16:31 ` segher at gcc dot gnu.org
@ 2021-11-10 16:38 ` segher at gcc dot gnu.org
2021-11-11 16:29 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: segher at gcc dot gnu.org @ 2021-11-10 16:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #8 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Note that the -mcpu= in use can be set by compiler defaults as well (which
can be set at build time, --with-cpu=), or commonly in RUNTESTFLAGS (to test
a bunch of different -mcpu= settings at the same time, say).
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (9 preceding siblings ...)
2021-11-10 16:38 ` segher at gcc dot gnu.org
@ 2021-11-11 16:29 ` marxin at gcc dot gnu.org
2021-11-11 18:03 ` segher at gcc dot gnu.org
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-11 16:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
All right, so something like this should work, right?
diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
index 3c6ae49f212..851b54e68b1 100644
--- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
+++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
@@ -36,4 +36,4 @@ int main (int argc, char **argv)
return 0;
}
-/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
\ No newline at end of file
+/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target {
!powerpc*-*-* || has_arch_pwr8 } } } } */
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (10 preceding siblings ...)
2021-11-11 16:29 ` marxin at gcc dot gnu.org
@ 2021-11-11 18:03 ` segher at gcc dot gnu.org
2021-11-11 18:44 ` schwab@linux-m68k.org
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: segher at gcc dot gnu.org @ 2021-11-11 18:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #10 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #9)
> All right, so something like this should work, right?
>
> diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
> b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
> index 3c6ae49f212..851b54e68b1 100644
> --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
> +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s112.c
> @@ -36,4 +36,4 @@ int main (int argc, char **argv)
> return 0;
> }
>
> -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
> \ No newline at end of file
> +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target
> { !powerpc*-*-* || has_arch_pwr8 } } } } */
Tcl's || is short-circuiting, so that should work yes. But put that
newline where it should be. And there should be a space after the !
I think? Never sure about that (it's not Tcl, it's parsed manually
by DG, the rules are different).
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (11 preceding siblings ...)
2021-11-11 18:03 ` segher at gcc dot gnu.org
@ 2021-11-11 18:44 ` schwab@linux-m68k.org
2021-11-12 14:24 ` cvs-commit at gcc dot gnu.org
2021-11-12 14:24 ` marxin at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: schwab@linux-m68k.org @ 2021-11-11 18:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #11 from Andreas Schwab <schwab@linux-m68k.org> ---
Target selectors are not arbitrary Tcl expressions. The parser requires all
operators and operands to be separate list elements (see selector_expression in
target-supports-dg.exp).
{ target { { ! powerpc*-*-* } || has_arch_pwr8 } }
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (12 preceding siblings ...)
2021-11-11 18:44 ` schwab@linux-m68k.org
@ 2021-11-12 14:24 ` cvs-commit at gcc dot gnu.org
2021-11-12 14:24 ` marxin at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-12 14:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:6849c71c065e599282c98f3678f22ac52d97a755
commit r12-5198-g6849c71c065e599282c98f3678f22ac52d97a755
Author: Martin Liska <mliska@suse.cz>
Date: Thu Nov 11 17:31:56 2021 +0100
testsuite: Filter out TSVC test on Power [PR103051]
PR testsuite/103051
gcc/testsuite/ChangeLog:
* gcc.dg/vect/tsvc/vect-tsvc-s112.c: Skip test for old Power
CPUs.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug testsuite/103051] [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840
2021-11-02 21:16 [Bug testsuite/103051] New: [12 regression] new test case gcc.dg/vect/tsvc/vect-tsvc-s112.c fails in r12-4840 seurer at gcc dot gnu.org
` (13 preceding siblings ...)
2021-11-12 14:24 ` cvs-commit at gcc dot gnu.org
@ 2021-11-12 14:24 ` marxin at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-12 14:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103051
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #13 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for the help, pushed.
^ permalink raw reply [flat|nested] 16+ messages in thread