public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/103052] [9/10/11 Regression] Function is found to be pure looping but has a call to a noreturn function in it Date: Thu, 25 Nov 2021 11:29:32 +0000 [thread overview] Message-ID: <bug-103052-4-9GKiqIi5iw@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103052-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103052 --- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-11 branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>: https://gcc.gnu.org/g:6a1358f7ea1111475e9d46c1535656bdfb2a7904 commit r11-9310-g6a1358f7ea1111475e9d46c1535656bdfb2a7904 Author: Jan Hubicka <jh@suse.cz> Date: Sun Nov 21 00:35:22 2021 +0100 Fix looping flag discovery in ipa-pure-const The testcase shows situation where there is non-trivial cycle in the callgraph involving a noreturn call. This cycle is important for const function discovery but not important for pure. IPA pure const uses same strongly connected components for both propagations which makes it to get suboptimal result (does not detect the pure flag). However local pure const gets the situation right becaue it processes functions in right order. This hits rarely executed code in propagate_pure_const that merge results with previously known state that has long standing bug in it that makes it to throw away the looping flag. Bootstrapped/regtested x86_64-linux. gcc/ChangeLog: 2021-11-21 Jan Hubicka <hubicka@ucw.cz> PR ipa/103052 * ipa-pure-const.c (propagate_pure_const): Fix merging of loping flag. gcc/testsuite/ChangeLog: 2021-11-21 Jan Hubicka <hubicka@ucw.cz> PR ipa/103052 * gcc.c-torture/execute/pr103052.c: New test. (cherry picked from commit a0e99d5bb741d3db74a67d492f47b28217fbf88a)
next prev parent reply other threads:[~2021-11-25 11:29 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-02 21:45 [Bug c/103052] New: Function call omitted at -O1 optimization level tor at ccxvii dot net 2021-11-02 22:04 ` [Bug c/103052] " jakub at gcc dot gnu.org 2021-11-02 22:09 ` tor at ccxvii dot net 2021-11-02 22:15 ` [Bug middle-end/103052] " pinskia at gcc dot gnu.org 2021-11-02 22:16 ` [Bug middle-end/103052] [9/10/11/12 Regression] " pinskia at gcc dot gnu.org 2021-11-02 22:19 ` tor at ccxvii dot net 2021-11-02 22:39 ` [Bug ipa/103052] " pinskia at gcc dot gnu.org 2021-11-02 22:41 ` pinskia at gcc dot gnu.org 2021-11-03 8:31 ` [Bug ipa/103052] [9/10/11/12 Regression] Function is found to be pure looping but has a call to a noreturn function in it rguenth at gcc dot gnu.org 2021-11-03 8:35 ` marxin at gcc dot gnu.org 2021-11-03 8:44 ` hubicka at gcc dot gnu.org 2021-11-19 12:47 ` hubicka at gcc dot gnu.org 2021-11-20 23:35 ` cvs-commit at gcc dot gnu.org 2021-11-20 23:40 ` cvs-commit at gcc dot gnu.org 2021-11-25 11:25 ` [Bug ipa/103052] [9/10/11 " cvs-commit at gcc dot gnu.org 2021-11-25 11:29 ` cvs-commit at gcc dot gnu.org [this message] 2021-11-25 13:29 ` cvs-commit at gcc dot gnu.org 2021-11-25 13:29 ` hubicka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103052-4-9GKiqIi5iw@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).