[Bug fortran/103054] New: [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[Bug fortran/103054] New: [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[damian at sourceryinstitute dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

            Bug ID: 103054
           Summary: [f18] Gfortran accepts invalid and rejects valid
                    co_reduce argument keyword name
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: damian at sourceryinstitute dot org
  Target Milestone: ---

In TS 18508, the second summy argument to co_reduce had the keyword name
"operator."  In the Fortran 2018 standard, the corresponding argument has the
name "operation."  GFortran accepts the non-standard keyword argument name
"operator" and rejects the standard name "operation."

% cat co_reduce.f90 
  implicit none
  logical :: co_all= .true.
  call co_reduce(co_all, operator=both)
  call co_reduce(co_all, operation=both)
contains
  logical pure function both(lhs,rhs)
    logical, intent(in) :: lhs, rhs
    both = lhs .and. rhs
  end function
end

⌁74% [rouson:~] % gfortran -fcoarray=single co_reduce.f90 
co_reduce.f90:4:40:

    4 |   call co_reduce(co_all, operation=both)
      |                                        1
Error: Cannot find keyword named 'operation' in call to 'co_reduce' at (1)
% gfortran --version
GNU Fortran (Homebrew GCC 11.2.0) 11.2.0

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #1 from kargl at gcc dot gnu.org ---
diff --git a/gcc/fortran/intrinsic.c b/gcc/fortran/intrinsic.c
index 219f04f2317..0e3dfd9e5e6 100644
--- a/gcc/fortran/intrinsic.c
+++ b/gcc/fortran/intrinsic.c
@@ -3805,7 +3805,7 @@ add_subroutines (void)
              BT_UNKNOWN, 0, GFC_STD_F2018,
              gfc_check_co_reduce, NULL, NULL,
              a, BT_REAL, dr, REQUIRED, INTENT_INOUT,
-             "operator", BT_INTEGER, di, REQUIRED, INTENT_IN,
+             "operation", BT_INTEGER, di, REQUIRED, INTENT_IN,
              result_image, BT_INTEGER, di, OPTIONAL, INTENT_IN,
              stat, BT_INTEGER, di, OPTIONAL, INTENT_OUT,
              errmsg, BT_CHARACTER, dc, OPTIONAL, INTENT_INOUT);

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-11-07
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[jvdelisle2 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

Jerry DeLisle <jvdelisle2 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle2 at gmail dot com

--- Comment #3 from Jerry DeLisle <jvdelisle2 at gmail dot com> ---
I will commit as obvious.

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

--- Comment #4 from kargl at gcc dot gnu.org ---
Created attachment 51745
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51745&action=edit
documentation update

Forgot the documentation part of the patch.

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

--- Comment #5 from anlauf at gcc dot gnu.org ---
Please have a look at the testsuite, too.

[Bug fortran/103054] [f18] Gfortran accepts invalid and rejects valid co_reduce argument keyword name

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103054

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |tkoenig at gcc dot gnu.org

--- Comment #6 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed by https://gcc.gnu.org/g:962ff7d2849e1fa6a1fe0535aa2dec5c2b9a32a6

Thanks for the bug report!