[Bug middle-end/103070] New: [12 regression] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[Bug middle-end/103070] New: [12 regression] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

            Bug ID: 103070
           Summary: [12 regression] ICE in gimple_call_static_chain_flags,
                    at gimple.c:1669
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11, sparc-sun-solaris2.11

Between 20211102 (c33a5cc9e7f1475108892abb147f9382ecbaec12) and 20211103
(600dcd74b8e614c996b492d97878660faf484094),
gnat.dg/lto21.adb started to FAIL:

+FAIL: gnat.dg/lto21.adb (internal compiler error)
+FAIL: gnat.dg/lto21.adb (test for excess errors)

Seen on Solaris 11/SPARC and x86 (32 and 64-bit).
during GIMPLE pass: alias
/var/gcc/regression/master/11.4-gcc/build/sparc-sun-solaris2.11/./libada/adainclude/a-cohama.adb:
In function 'lto21_pkg2__proc__maps__reserve_capacity':
/var/gcc/regression/master/11.4-gcc/build/sparc-sun-solaris2.11/./libada/adainclude/a-cohama.adb:1104:4:
internal compiler error: in gimple_call_static_chain_flags, at gimple.c:1669
0x862a37 gimple_call_static_chain_flags(gcall const*)
        /vol/gcc/src/hg/master/local/gcc/gimple.c:1669
0xecc987 handle_rhs_call
        /vol/gcc/src/hg/master/local/gcc/tree-ssa-structalias.c:4258
0xed03a7 find_func_aliases_for_call
        /vol/gcc/src/hg/master/local/gcc/tree-ssa-structalias.c:4921
0xed03a7 find_func_aliases
        /vol/gcc/src/hg/master/local/gcc/tree-ssa-structalias.c:5024
0xed25cf compute_points_to_sets
        /vol/gcc/src/hg/master/local/gcc/tree-ssa-structalias.c:7440
0xed25cf compute_may_aliases()
        /vol/gcc/src/hg/master/local/gcc/tree-ssa-structalias.c:7948
0xb16b03 execute_function_todo
        /vol/gcc/src/hg/master/local/gcc/passes.c:2014
0xb17573 do_per_function
        /vol/gcc/src/hg/master/local/gcc/passes.c:1687
0xb1772b execute_todo
        /vol/gcc/src/hg/master/local/gcc/passes.c:2096

This was probably caused by
commit a70c05120ae6f15f204a04a7df7d19941ab33ef1
Author: Jan Hubicka <hubicka@ucw.cz>
Date:   Tue Nov 2 18:57:51 2021 +0100

    Static chain support in ipa-modref

[Bug middle-end/103070] [12 regression] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug ada/103070] [12 regression] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
          Component|ipa                         |ada
   Last reconfirmed|                            |2021-11-04

--- Comment #1 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Confirmed. Also reproduces on x86_64-linux.

The test is checking that nested functions are not interposable.  I think all
nested functions should be static since they can not be called cross-module
(since their ABI depends on outer function frame layout).  So I think this
would be best fixed on Ada frotend side.

Note that I have silenced the sanity check for now to unbreak some Fortran
builds.

[Bug ada/103070] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 regression] ICE in      |ICE in
                   |gimple_call_static_chain_fl |gimple_call_static_chain_fl
                   |ags, at gimple.c:1669       |ags, at gimple.c:1669
   Target Milestone|12.0                        |---
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The ICE should be gone, the Ada FE should still be fixed.

[Bug ada/103070] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:6078eb7452aa89cb9aeecac30932b58967389459

commit r12-4974-g6078eb7452aa89cb9aeecac30932b58967389459
Author: Jan Hubicka <hubicka@ucw.cz>
Date:   Sat Nov 6 23:36:08 2021 +0100

    Fix can_be_discarded_p wrt partitioned functions.

    gcc/ChangeLog:

            * cgraph.h (cgraph_node::can_be_discarded_p): Do not
            return true on functions from other partition.

    gcc/lto/ChangeLog:

            PR ipa/103070
            PR ipa/103058
            * lto-partition.c (must_not_rename): Update comment.
            (promote_symbol): Set resolution to LDPR_PREVAILING_DEF_IRONLY.

[Bug ada/103070] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
This has turned out to be (somewhat subtle) but in partitioning. I apologize
for blaming the front-end.

[Bug ada/103070] ICE in gimple_call_static_chain_flags, at gimple.c:1669

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103070
Bug 103070 depends on bug 103058, which changed state.

Bug 103058 Summary: [12 Regression] ICE in gimple_call_static_chain_flags, at gimple.c:1669 when building 527.cam4_r
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103058

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED