public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/103105] [11/12 Regression] ICE iterative_hash_template_arg with concepts and varagrs template since r11-3261-gb28b621ac67beee8
Date: Tue, 12 Apr 2022 16:59:25 +0000	[thread overview]
Message-ID: <bug-103105-4-AIx85rycHW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103105-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103105

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:e2c7070ac7740508a7c49bfee9f895e216a272d6

commit r12-8110-ge2c7070ac7740508a7c49bfee9f895e216a272d6
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Apr 12 12:58:18 2022 -0400

    c++: requires-expr in pack expansion using pack [PR103105]

    Here after dependent substitution of {Ts...} into the alias 'wrap',
    since we never partially instantiate a requires-expr, we end up with a
    requires-expr whose REQUIRES_EXPR_EXTRA_ARGS contains an
    ARGUMENT_PACK_SELECT (which just resolves to the parameter pack Ts).
    Then when hashing the resulting dependent specialization of A, we crash
    from iterative_hash_template_arg since it deliberately doesn't handle
    ARGUMENT_PACK_SELECT.

    Like in r12-7102-gdb5f1c17031ad8, it seems the right fix here is to
    resolve ARGUMENT_PACK_SELECT arguments before storing them into an
    extra args tree (such as REQUIRES_EXPR).

            PR c++/103105

    gcc/cp/ChangeLog:

            * pt.cc (build_extra_args): Call preserve_args.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/concepts-requires29.C: New test.
            * g++.dg/cpp2a/concepts-requires29a.C: New test.

  parent reply	other threads:[~2022-04-12 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-06  1:24 [Bug c++/103105] New: [11 Regression] ICE iterative_hash_template_arg, at cp/pt.c:1790 jonathan.poelen at gmail dot com
2021-11-06  4:49 ` [Bug c++/103105] [11/12 Regression] ICE iterative_hash_template_arg with concepts and varagrs template pinskia at gcc dot gnu.org
2021-11-06  5:00 ` pinskia at gcc dot gnu.org
2021-11-06  8:19 ` [Bug c++/103105] [11/12 Regression] ICE iterative_hash_template_arg with concepts and varagrs template since r11-3261-gb28b621ac67beee8 marxin at gcc dot gnu.org
2021-11-06 14:05 ` ppalka at gcc dot gnu.org
2021-11-08  9:12 ` rguenth at gcc dot gnu.org
2022-04-12 16:59 ` cvs-commit at gcc dot gnu.org [this message]
2022-04-12 16:59 ` [Bug c++/103105] [11 " ppalka at gcc dot gnu.org
2022-04-12 20:24 ` jason at gcc dot gnu.org
2022-04-12 23:44 ` cvs-commit at gcc dot gnu.org
2022-04-12 23:46 ` ppalka at gcc dot gnu.org
2022-04-12 23:49 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103105-4-AIx85rycHW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).