public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103121] [12 Regression] Warnings in cp/optimize.c causing build failure
Date: Mon, 08 Nov 2021 21:11:59 +0000	[thread overview]
Message-ID: <bug-103121-4-s67AGHQBh1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103121-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103121

--- Comment #11 from Andrew Macleod <amacleod at redhat dot com> ---
(In reply to Martin Sebor from comment #10)
> Sorry, I've been having trouble with GDB and so I'm running two GDB sessions
> and I have been mixing output from both of them.  I see the warning for the
> store to *_23 in BB 13, not for BB 12.  Here's a fresh session as a sanity
> check:
> 
> 
> Breakpoint 1, strlen_pass::maybe_warn_overflow (this=0x7fffffffd880,
> stmt=0x7ffff4c2eb40, call_lhs=true, len=1, si=0x0, plus_one=false,
> rawmem=false) at /src/gcc/master/gcc/tree-ssa-strlen.c:2181
> 2181	  tree tlen = build_int_cst (size_type_node, len);
> (gdb) p debug(gimple_bb(stmt))
> <bb 13> [local count: 105119324]:
> _23 = grp_name_37 + idx_47;
> *_23 = 0;
> if (diff_seen_24 != 0)
>   goto <bb 15>; [100.00%]
> else
>   goto <bb 14>; [0.00%]
> 
> $3 = void
> (gdb) c
> Continuing.
> ../../gcc/gcc/cp/optimize.c: In function 'tree_node*
> cdtor_comdat_group(tree, tree)':
> ../../gcc/gcc/cp/optimize.c:208:17: warning: writing 1 byte into a region of
> size 0 [-Wstringop-overflow=]
> ../../gcc/gcc/cp/optimize.c:191:40: note: at offset 1 into destination
> object of size 1 allocated by '__builtin_alloca'
> [Inferior 1 (process 11409) exited normally]

Im still not sure what you are asking, or think is wrong.  I don't see any
ranges here.  Presumably the range of _4 is [0,0][2,+INF] at this point since
we've take the other branch.

If you haven't switched to multi-ranges and are still using value_range, then
presumably you would see ~[1,1]

Which means its possible that _4 was 0 on this branch, which also means the
warning would trigger?

The way the IL reads, if _1 is MAX_INT, then _4 is 0, and that gets through on
the 4->16 edge...

Am I missing something?

  parent reply	other threads:[~2021-11-08 21:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 22:33 [Bug other/103121] New: Warnings danglin at gcc dot gnu.org
2021-11-08  8:19 ` [Bug other/103121] [12 Regression] Warnings in cp/optimize.c causing build failure pinskia at gcc dot gnu.org
2021-11-08  9:24 ` [Bug tree-optimization/103121] " rguenth at gcc dot gnu.org
2021-11-08 13:19 ` dave.anglin at bell dot net
2021-11-08 16:08 ` msebor at gcc dot gnu.org
2021-11-08 16:19 ` danglin at gcc dot gnu.org
2021-11-08 19:00 ` msebor at gcc dot gnu.org
2021-11-08 19:04 ` msebor at gcc dot gnu.org
2021-11-08 19:36 ` amacleod at redhat dot com
2021-11-08 19:50 ` msebor at gcc dot gnu.org
2021-11-08 20:07 ` amacleod at redhat dot com
2021-11-08 20:48 ` msebor at gcc dot gnu.org
2021-11-08 21:11 ` amacleod at redhat dot com [this message]
2021-11-08 21:48 ` msebor at gcc dot gnu.org
2021-11-08 22:35 ` msebor at gcc dot gnu.org
2021-11-09  0:01 ` amacleod at redhat dot com
2021-11-09  1:11 ` msebor at gcc dot gnu.org
2021-11-09  7:20 ` aldyh at gcc dot gnu.org
2021-11-09  7:24 ` aldyh at gcc dot gnu.org
2021-11-09  8:22 ` rguenth at gcc dot gnu.org
2022-01-18 14:34 ` rguenth at gcc dot gnu.org
2022-01-18 20:18 ` amacleod at redhat dot com
2022-01-19  7:36 ` rguenther at suse dot de
2022-01-19 17:50 ` amacleod at redhat dot com
2022-01-20  7:22 ` rguenther at suse dot de
2022-01-20  7:25 ` rguenth at gcc dot gnu.org
2022-01-20 15:49 ` amacleod at redhat dot com
2022-01-20 16:14 ` msebor at gcc dot gnu.org
2022-01-20 17:14 ` danglin at gcc dot gnu.org
2022-01-21  7:27 ` rguenther at suse dot de
2022-01-21 16:16 ` msebor at gcc dot gnu.org
2022-01-21 17:53 ` amacleod at redhat dot com
2022-01-21 18:59 ` msebor at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103121-4-s67AGHQBh1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).