* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
@ 2021-11-10 18:25 ` redi at gcc dot gnu.org
2021-11-10 21:29 ` redi at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-11-10 18:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|internal compiler error: in |[12 Regression] internal
|handle_call_arg, at |compiler error: in
|tree-ssa-structalias.c:4139 |handle_call_arg, at
| |tree-ssa-structalias.c:4139
Known to work| |11.2.1
Build|powerpc64le-unknown-linux-g |
|nu |
Known to fail| |12.0
Target|powerpc64le-unknown-linux-g |
|nu |
Host|powerpc64le-unknown-linux-g |
|nu |
CC| |hubicka at gcc dot gnu.org
Last reconfirmed| |2021-11-10
Target Milestone|--- |12.0
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Affects at least powerpc64le-unknown-linux-gnu and x86_64-pc-linux-gnu
Started with g:d70ef65692fced7ab72e0aceeff7407e5a34d96d
"Make EAF flags more regular (and expressive)"
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
2021-11-10 18:25 ` [Bug tree-optimization/103175] [12 Regression] " redi at gcc dot gnu.org
@ 2021-11-10 21:29 ` redi at gcc dot gnu.org
2021-11-10 23:11 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-11-10 21:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
FAIL: 18_support/nested_exception/rethrow_if_nested.cc (test for excess errors)
FAIL: 20_util/variant/exception_safety.cc (test for excess errors)
FAIL: 20_util/variant/run.cc (test for excess errors)
FAIL: std/ranges/adaptors/join.cc (test for excess errors)
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
2021-11-10 18:25 ` [Bug tree-optimization/103175] [12 Regression] " redi at gcc dot gnu.org
2021-11-10 21:29 ` redi at gcc dot gnu.org
@ 2021-11-10 23:11 ` pinskia at gcc dot gnu.org
2021-11-11 9:16 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-10 23:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |seurer at gcc dot gnu.org
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 103178 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (2 preceding siblings ...)
2021-11-10 23:11 ` pinskia at gcc dot gnu.org
@ 2021-11-11 9:16 ` rguenth at gcc dot gnu.org
2021-11-11 17:42 ` seurer at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-11-11 9:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (3 preceding siblings ...)
2021-11-11 9:16 ` rguenth at gcc dot gnu.org
@ 2021-11-11 17:42 ` seurer at gcc dot gnu.org
2021-11-11 17:47 ` Jan Hubicka
2021-11-11 17:47 ` hubicka at kam dot mff.cuni.cz
` (4 subsequent siblings)
9 siblings, 1 reply; 12+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-11-11 17:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #4 from seurer at gcc dot gnu.org ---
Also this one which fails but doesn't ICE
g:d70ef65692fced7ab72e0aceeff7407e5a34d96d, r12-5113
make -k check-gcc-fortran
RUNTESTFLAGS="dg.exp=gfortran.dg/inline_matmul_17.f90"
FAIL: gfortran.dg/inline_matmul_17.f90 -O scan-tree-dump-times optimized
"matmul_r4" 2
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-11 17:42 ` seurer at gcc dot gnu.org
@ 2021-11-11 17:47 ` Jan Hubicka
0 siblings, 0 replies; 12+ messages in thread
From: Jan Hubicka @ 2021-11-11 17:47 UTC (permalink / raw)
To: seurer at gcc dot gnu.org; +Cc: gcc-bugs
The sanity check verifies that functions acessing parameter indirectly
also reads the parameter (otherwise the indirect reference can not
happen). This patch moves the check earlier and removes some overactive
flag cleaning on function call boundary which introduces the non-sential
situation. I got bit paranoid here on how return value relates to
escaping solution.
as discussed on ML, matmul failure is simply the fact that the testcase
verified missed optimization is still misssed.
diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index 72006251f29..a97021c6c60 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1681,6 +1681,13 @@ modref_lattice::merge (int f)
{
if (f & EAF_UNUSED)
return false;
+ /* Check that flags seems sane: if function does not read the parameter
+ it can not access it indirectly. */
+ gcc_checking_assert (!(f & EAF_NO_DIRECT_READ)
+ || ((f & EAF_NO_INDIRECT_READ)
+ && (f & EAF_NO_INDIRECT_CLOBBER)
+ && (f & EAF_NO_INDIRECT_ESCAPE)
+ && (f & EAF_NOT_RETURNED_INDIRECTLY)));
if ((flags & f) != flags)
{
flags &= f;
@@ -1874,27 +1881,13 @@ modref_eaf_analysis::merge_call_lhs_flags (gcall *call, int arg,
argument if needed. */
static int
-callee_to_caller_flags (int call_flags, bool ignore_stores,
- modref_lattice &lattice)
+callee_to_caller_flags (int call_flags, bool ignore_stores)
{
/* call_flags is about callee returning a value
that is not the same as caller returning it. */
call_flags |= EAF_NOT_RETURNED_DIRECTLY
| EAF_NOT_RETURNED_INDIRECTLY;
- /* TODO: We miss return value propagation.
- Be conservative and if value escapes to memory
- also mark it as escaping. */
- if (!ignore_stores && !(call_flags & EAF_UNUSED))
- {
- if (!(call_flags & EAF_NO_DIRECT_ESCAPE))
- lattice.merge (~(EAF_NOT_RETURNED_DIRECTLY
- | EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED));
- if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
- lattice.merge (~(EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED));
- }
- else
+ if (ignore_stores)
call_flags |= ignore_stores_eaf_flags;
return call_flags;
}
@@ -2033,15 +2026,9 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
if (!(call_flags & (EAF_NOT_RETURNED_DIRECTLY
| EAF_UNUSED)))
m_lattice[index].merge (~(EAF_NO_DIRECT_ESCAPE
- | EAF_NO_INDIRECT_ESCAPE
- | EAF_UNUSED));
- if (!(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED)))
- m_lattice[index].merge (~(EAF_NO_INDIRECT_ESCAPE
| EAF_UNUSED));
call_flags = callee_to_caller_flags
- (call_flags, false,
- m_lattice[index]);
+ (call_flags, false);
}
m_lattice[index].merge (call_flags);
}
@@ -2057,8 +2044,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
!(call_flags & EAF_NOT_RETURNED_DIRECTLY),
!(call_flags & EAF_NOT_RETURNED_INDIRECTLY));
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!(ecf_flags & (ECF_CONST | ECF_NOVOPS)))
m_lattice[index].merge (call_flags);
}
@@ -2082,8 +2068,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
if (!(ecf_flags & (ECF_CONST | ECF_NOVOPS)))
{
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!record_ipa)
m_lattice[index].merge (call_flags);
else
@@ -2105,8 +2090,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
else
{
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!record_ipa)
m_lattice[index].merge (call_flags);
else
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (4 preceding siblings ...)
2021-11-11 17:42 ` seurer at gcc dot gnu.org
@ 2021-11-11 17:47 ` hubicka at kam dot mff.cuni.cz
2021-11-11 19:42 ` dcb314 at hotmail dot com
` (3 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: hubicka at kam dot mff.cuni.cz @ 2021-11-11 17:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #5 from hubicka at kam dot mff.cuni.cz ---
The sanity check verifies that functions acessing parameter indirectly
also reads the parameter (otherwise the indirect reference can not
happen). This patch moves the check earlier and removes some overactive
flag cleaning on function call boundary which introduces the non-sential
situation. I got bit paranoid here on how return value relates to
escaping solution.
as discussed on ML, matmul failure is simply the fact that the testcase
verified missed optimization is still misssed.
diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index 72006251f29..a97021c6c60 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1681,6 +1681,13 @@ modref_lattice::merge (int f)
{
if (f & EAF_UNUSED)
return false;
+ /* Check that flags seems sane: if function does not read the parameter
+ it can not access it indirectly. */
+ gcc_checking_assert (!(f & EAF_NO_DIRECT_READ)
+ || ((f & EAF_NO_INDIRECT_READ)
+ && (f & EAF_NO_INDIRECT_CLOBBER)
+ && (f & EAF_NO_INDIRECT_ESCAPE)
+ && (f & EAF_NOT_RETURNED_INDIRECTLY)));
if ((flags & f) != flags)
{
flags &= f;
@@ -1874,27 +1881,13 @@ modref_eaf_analysis::merge_call_lhs_flags (gcall *call,
int arg,
argument if needed. */
static int
-callee_to_caller_flags (int call_flags, bool ignore_stores,
- modref_lattice &lattice)
+callee_to_caller_flags (int call_flags, bool ignore_stores)
{
/* call_flags is about callee returning a value
that is not the same as caller returning it. */
call_flags |= EAF_NOT_RETURNED_DIRECTLY
| EAF_NOT_RETURNED_INDIRECTLY;
- /* TODO: We miss return value propagation.
- Be conservative and if value escapes to memory
- also mark it as escaping. */
- if (!ignore_stores && !(call_flags & EAF_UNUSED))
- {
- if (!(call_flags & EAF_NO_DIRECT_ESCAPE))
- lattice.merge (~(EAF_NOT_RETURNED_DIRECTLY
- | EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED));
- if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
- lattice.merge (~(EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED));
- }
- else
+ if (ignore_stores)
call_flags |= ignore_stores_eaf_flags;
return call_flags;
}
@@ -2033,15 +2026,9 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
if (!(call_flags & (EAF_NOT_RETURNED_DIRECTLY
| EAF_UNUSED)))
m_lattice[index].merge (~(EAF_NO_DIRECT_ESCAPE
- | EAF_NO_INDIRECT_ESCAPE
- | EAF_UNUSED));
- if (!(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
- | EAF_UNUSED)))
- m_lattice[index].merge (~(EAF_NO_INDIRECT_ESCAPE
| EAF_UNUSED));
call_flags = callee_to_caller_flags
- (call_flags, false,
- m_lattice[index]);
+ (call_flags, false);
}
m_lattice[index].merge (call_flags);
}
@@ -2057,8 +2044,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
!(call_flags & EAF_NOT_RETURNED_DIRECTLY),
!(call_flags & EAF_NOT_RETURNED_INDIRECTLY));
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!(ecf_flags & (ECF_CONST | ECF_NOVOPS)))
m_lattice[index].merge (call_flags);
}
@@ -2082,8 +2068,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
if (!(ecf_flags & (ECF_CONST | ECF_NOVOPS)))
{
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!record_ipa)
m_lattice[index].merge (call_flags);
else
@@ -2105,8 +2090,7 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
else
{
call_flags = callee_to_caller_flags
- (call_flags, ignore_stores,
- m_lattice[index]);
+ (call_flags, ignore_stores);
if (!record_ipa)
m_lattice[index].merge (call_flags);
else
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (5 preceding siblings ...)
2021-11-11 17:47 ` hubicka at kam dot mff.cuni.cz
@ 2021-11-11 19:42 ` dcb314 at hotmail dot com
2021-11-12 15:35 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: dcb314 at hotmail dot com @ 2021-11-11 19:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #6 from David Binderman <dcb314 at hotmail dot com> ---
Created attachment 51773
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51773&action=edit
gzipped C++ source code
Another test case. Flag -O1 required.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (6 preceding siblings ...)
2021-11-11 19:42 ` dcb314 at hotmail dot com
@ 2021-11-12 15:35 ` cvs-commit at gcc dot gnu.org
2021-11-12 15:37 ` hubicka at gcc dot gnu.org
2021-11-13 9:34 ` redi at gcc dot gnu.org
9 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-12 15:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:
https://gcc.gnu.org/g:4526ec20f17a6182f754da9460d9d944dd123cc0
commit r12-5201-g4526ec20f17a6182f754da9460d9d944dd123cc0
Author: Jan Hubicka <jh@suse.cz>
Date: Fri Nov 12 16:34:03 2021 +0100
Fix ICE in tree-ssa-structalias.c
PR tree-optimization/103175
* ipa-modref.c (modref_lattice::merge): Add sanity check.
(callee_to_caller_flags): Make flags adjustment sane.
(modref_eaf_analysis::analyze_ssa_name): Likewise.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (7 preceding siblings ...)
2021-11-12 15:35 ` cvs-commit at gcc dot gnu.org
@ 2021-11-12 15:37 ` hubicka at gcc dot gnu.org
2021-11-13 9:34 ` redi at gcc dot gnu.org
9 siblings, 0 replies; 12+ messages in thread
From: hubicka at gcc dot gnu.org @ 2021-11-12 15:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug tree-optimization/103175] [12 Regression] internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139
2021-11-10 18:14 [Bug tree-optimization/103175] New: internal compiler error: in handle_call_arg, at tree-ssa-structalias.c:4139 redi at gcc dot gnu.org
` (8 preceding siblings ...)
2021-11-12 15:37 ` hubicka at gcc dot gnu.org
@ 2021-11-13 9:34 ` redi at gcc dot gnu.org
9 siblings, 0 replies; 12+ messages in thread
From: redi at gcc dot gnu.org @ 2021-11-13 9:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103175
--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Thanks!
^ permalink raw reply [flat|nested] 12+ messages in thread