public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug jit/103199] New: FAIL: ../jit/docs/examples/tut04-toyvm/toyvm.c, initial compilation
@ 2021-11-11 20:09 msebor at gcc dot gnu.org
2021-11-12 13:21 ` [Bug jit/103199] " cvs-commit at gcc dot gnu.org
2021-11-12 14:12 ` dmalcolm at gcc dot gnu.org
0 siblings, 2 replies; 3+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-11-11 20:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103199
Bug ID: 103199
Summary: FAIL: ../jit/docs/examples/tut04-toyvm/toyvm.c,
initial compilation
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: jit
Assignee: dmalcolm at gcc dot gnu.org
Reporter: msebor at gcc dot gnu.org
Target Milestone: ---
A recent regression test run shows FAILs in a couple of JIT example programs,
both due to -Wformat-overflow errors:
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.c:
In function 'toyvm_function_compile':
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.c:565:29:
error: 'sprintf' may write a terminating nul past the end of the destination
[-Werror=format-overflow=]
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.c:565:7:
note: 'sprintf' output between 7 and 17 bytes into a destination of size 16
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.cc:
In member function 'void compilation_state::create_function(const char*)':
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.cc:637:29:
error: 'sprintf' may write a terminating nul past the end of the destination
[-Werror=format-overflow=]
/build/gcc-master/gcc/testsuite/jit/jit.log:/src/gcc/master/gcc/testsuite/../jit/docs/examples/tut04-toyvm/toyvm.cc:637:15:
note: 'sprintf' output between 7 and 17 bytes into a destination of size 16
My best guess is that the recent change to convert the strlen pass away from
EVRP to ranger has enabled the warning thanks to better range info. Looking at
one of the call sites:
/* Create a block per operation. */
for (pc = 0; pc < fn->fn_num_ops; pc++)
{
char buf[16];
sprintf (buf, "instr%i", pc);
state.op_blocks[pc] = gcc_jit_function_new_block (state.fn, buf);
}
the buffer is just big enough to fit the string and a 32-bit nonnegative int.
But pc is a signed int and if its range as determined by ranger includes
negative values the warning will trigger.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-12 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 20:09 [Bug jit/103199] New: FAIL: ../jit/docs/examples/tut04-toyvm/toyvm.c, initial compilation msebor at gcc dot gnu.org
2021-11-12 13:21 ` [Bug jit/103199] " cvs-commit at gcc dot gnu.org
2021-11-12 14:12 ` dmalcolm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).