* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
@ 2021-11-12 7:43 ` rguenth at gcc dot gnu.org
2021-11-12 7:51 ` [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams' burnus at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-11-12 7:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Keywords| |build
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
2021-11-12 7:43 ` [Bug target/103201] " rguenth at gcc dot gnu.org
@ 2021-11-12 7:51 ` burnus at gcc dot gnu.org
2021-11-12 9:32 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-11-12 7:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ams at gcc dot gnu.org,
| |jakub at gcc dot gnu.org
Keywords| |openmp
Summary|[12 Regression] trunk |[12 Regression] trunk
|20211111 ftbfs for amdgcn |20211111 ftbfs for amdgcn –
| |libgomp/teams.c:49:6:
| |error: 'struct gomp_thread'
| |has no member named
| |'num_teams'
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Confirmed – likely due to Jakub's change for OpenMP 5.1, which has
num_teams(lower:upper) instead of only num_teams(val) in the clause.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
2021-11-12 7:43 ` [Bug target/103201] " rguenth at gcc dot gnu.org
2021-11-12 7:51 ` [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams' burnus at gcc dot gnu.org
@ 2021-11-12 9:32 ` marxin at gcc dot gnu.org
2021-11-12 9:43 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-12 9:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |marxin at gcc dot gnu.org
Last reconfirmed| |2021-11-12
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
` (2 preceding siblings ...)
2021-11-12 9:32 ` marxin at gcc dot gnu.org
@ 2021-11-12 9:43 ` jakub at gcc dot gnu.org
2021-11-12 15:07 ` ams at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-11-12 9:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 51777
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51777&action=edit
gcc12-pr103201.patch
I think this should fix it, but I currently don't have a way to test it.
I was relying on libgomp/teams.c not being compiled for the
!LIBGOMP_USE_PTHREAD targets...
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
` (3 preceding siblings ...)
2021-11-12 9:43 ` jakub at gcc dot gnu.org
@ 2021-11-12 15:07 ` ams at gcc dot gnu.org
2021-11-12 15:14 ` cvs-commit at gcc dot gnu.org
2021-11-15 12:12 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: ams at gcc dot gnu.org @ 2021-11-12 15:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
--- Comment #3 from Andrew Stubbs <ams at gcc dot gnu.org> ---
I did some preliminary testing on your patch: the libgomp.c/target-teams-1.c
testcase runs fine on amdgcn. I presume that that covers most of the existing
features of those runtime calls?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
` (4 preceding siblings ...)
2021-11-12 15:07 ` ams at gcc dot gnu.org
@ 2021-11-12 15:14 ` cvs-commit at gcc dot gnu.org
2021-11-15 12:12 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-12 15:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:f49c7a4fb23d82c89c97acec88770b300c903d9a
commit r12-5200-gf49c7a4fb23d82c89c97acec88770b300c903d9a
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Nov 12 16:11:02 2021 +0100
libgomp: Unbreak gcn offload build
My recent libgomp change apparently broke libgomp build for gcn offloading.
The problem is that gcn, unlike nvptx, doesn't override teams.c source file
and the patch I've committed assumed all the non-LIBGOMP_USE_PTHREADS
targets
do not use it. My understanding is that gcn included omp_get_num_teams
and omp_get_team_num definitions in both icv-device.o and teams.o,
with the definitions only in the former working correctly.
This patch brings gcn into sync with how nvptx does it, that teams.c
is overridden, provides a dummy GOMP_teams_reg and
omp_get_{num_teams,team_num}
definitions and icv-device.c doesn't provide those.
2021-11-12 Jakub Jelinek <jakub@redhat.com>
PR target/103201
* config/gcn/icv-device.c (omp_get_num_teams, omp_get_team_num):
Move
to ...
* config/gcn/teams.c: ... here. New file.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/103201] [12 Regression] trunk 20211111 ftbfs for amdgcn – libgomp/teams.c:49:6: error: 'struct gomp_thread' has no member named 'num_teams'
2021-11-11 21:43 [Bug target/103201] New: [12 Regression] trunk 20211111 ftbfs for amdgcn doko at debian dot org
` (5 preceding siblings ...)
2021-11-12 15:14 ` cvs-commit at gcc dot gnu.org
@ 2021-11-15 12:12 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-11-15 12:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103201
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.
^ permalink raw reply [flat|nested] 8+ messages in thread