public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103221] New: evrp removes |SIGN but does not propagate the ssa name
Date: Sat, 13 Nov 2021 06:54:27 +0000	[thread overview]
Message-ID: <bug-103221-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103221

            Bug ID: 103221
           Summary: evrp removes |SIGN but does not propagate the ssa name
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Take:
signed char f(signed char a)
{
  signed char v;
  v = a;
  if (a < 0)
    v = a | -128;
  return v;
}
---- CUT ----
EVRP is able to remove the | -128 part but still left with:
  if (a_2(D) < 0)
    goto <bb 3>; [INV]
  else
    goto <bb 4>; [INV]

  <bb 3> :
  v_4 = a_2(D);

  <bb 4> :
  # v_1 = PHI <a_2(D)(2), v_4(3)>
  return v_1;

But the PHI should be removed and the function should have been at this point
just "return a_2(D);".

Note this is not a regression and even the original VRP had a similar issue
too.

             reply	other threads:[~2021-11-13  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13  6:54 pinskia at gcc dot gnu.org [this message]
2021-11-15  9:01 ` [Bug tree-optimization/103221] " rguenth at gcc dot gnu.org
2021-11-23 20:20 ` amacleod at redhat dot com
2021-11-25 15:21 ` amacleod at redhat dot com
2021-12-25  9:59 ` pinskia at gcc dot gnu.org
2022-01-12 20:45 ` amacleod at redhat dot com
2022-01-12 20:52 ` pinskia at gcc dot gnu.org
2022-01-12 20:59 ` amacleod at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103221-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).