public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case
@ 2021-11-15 10:06 pinskia at gcc dot gnu.org
2021-11-15 10:10 ` [Bug tree-optimization/103245] " pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-15 10:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245
Bug ID: 103245
Summary: Failure to detect abs pattern using multiplication
with slightly different casts for unsigned case
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Keywords: missed-optimization
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Blocks: 103228
Target Milestone: ---
While working on PR 103228, I got the testcase for PR 94785 failing.
It fails if I change the casts even:
unsigned int f4 (int v)
{
unsigned int d_6;
int b_5;
int a_4;
_Bool _1;
unsigned int v1_2;
unsigned int _7;
int _9;
_1 = v < 0;
a_4 = (int) _1;
b_5 = -a_4;
_9 = b_5 | 1;
d_6 = (unsigned int) _9;
v1_2 = (unsigned int) v;
_7 = v1_2 * d_6;
return _7;
}
---- CUT ---
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103228
[Bug 103228] [9/10/11/12 Regression] missed optimization with |^ at the gimple
level
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/103245] Failure to detect abs pattern using multiplication with slightly different casts for unsigned case 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org @ 2021-11-15 10:10 ` pinskia at gcc dot gnu.org 2021-11-15 22:43 ` pinskia at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2021-11-15 10:10 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org Last reconfirmed| |2021-11-15 --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- I will handle this tomorrow. The current pattern matches: (simplify (mult:c (bit_ior (nop_convert (negate (convert? (lt @0 integer_zerop)))) integer_onep) (nop_convert @0)) We need to match also: (simplify (mult:c (nop_convert (bit_ior (negate (convert? (lt @0 integer_zerop))) integer_onep) (nop_convert @0)) ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/103245] Failure to detect abs pattern using multiplication with slightly different casts for unsigned case 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org 2021-11-15 10:10 ` [Bug tree-optimization/103245] " pinskia at gcc dot gnu.org @ 2021-11-15 22:43 ` pinskia at gcc dot gnu.org 2021-11-16 2:54 ` pinskia at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2021-11-15 22:43 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245 --- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Created attachment 51801 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51801&action=edit patch which I am testing I noticed the patterns could be combined together. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/103245] Failure to detect abs pattern using multiplication with slightly different casts for unsigned case 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org 2021-11-15 10:10 ` [Bug tree-optimization/103245] " pinskia at gcc dot gnu.org 2021-11-15 22:43 ` pinskia at gcc dot gnu.org @ 2021-11-16 2:54 ` pinskia at gcc dot gnu.org 2021-11-16 3:32 ` cvs-commit at gcc dot gnu.org 2021-11-16 3:33 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2021-11-16 2:54 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gcc.gnu.org/piperma | |il/gcc-patches/2021-Novembe | |r/584547.html Keywords|ra |patch --- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Patch submitted: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584547.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/103245] Failure to detect abs pattern using multiplication with slightly different casts for unsigned case 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org ` (2 preceding siblings ...) 2021-11-16 2:54 ` pinskia at gcc dot gnu.org @ 2021-11-16 3:32 ` cvs-commit at gcc dot gnu.org 2021-11-16 3:33 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2021-11-16 3:32 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>: https://gcc.gnu.org/g:3200de91bc70bfd6d4b7b40e769bc82756b9b555 commit r12-5291-g3200de91bc70bfd6d4b7b40e769bc82756b9b555 Author: Andrew Pinski <apinski@marvell.com> Date: Mon Nov 15 22:55:09 2021 +0000 tree-optimization: [PR103245] Improve detection of abs pattern using multiplication So while working on PR 103228 (and a few others), I noticed the testcase for PR 94785 was failing. The problem is that the nop_convert moved from being inside the IOR to be outside of it. I also noticed the patch for PR 103228 was not needed to reproduce the issue either. This patch combines the two patterns together for the abs match when using multiplication and adds a few places where nop_convert are optional. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. PR tree-optimization/103245 gcc/ChangeLog: * match.pd: Combine the abs pattern matching using multiplication. Adding optional nop_convert too. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr103245-1.c: New test. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/103245] Failure to detect abs pattern using multiplication with slightly different casts for unsigned case 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org ` (3 preceding siblings ...) 2021-11-16 3:32 ` cvs-commit at gcc dot gnu.org @ 2021-11-16 3:33 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2021-11-16 3:33 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103245 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Target Milestone|--- |12.0 --- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-16 3:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-11-15 10:06 [Bug tree-optimization/103245] New: Failure to detect abs pattern using multiplication with slightly different casts for unsigned case pinskia at gcc dot gnu.org 2021-11-15 10:10 ` [Bug tree-optimization/103245] " pinskia at gcc dot gnu.org 2021-11-15 22:43 ` pinskia at gcc dot gnu.org 2021-11-16 2:54 ` pinskia at gcc dot gnu.org 2021-11-16 3:32 ` cvs-commit at gcc dot gnu.org 2021-11-16 3:33 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).