public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/103246] [12 Regression] 416.gamess miscompare with -O2 -g -flto=auto since r12-5223-gecdf414bd89e6ba251f6b3f494407139b4dbae0e
Date: Thu, 18 Nov 2021 19:10:18 +0000	[thread overview]
Message-ID: <bug-103246-4-hEFnjQYE1N@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103246-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103246

--- Comment #25 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jan Hubicka
<hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:9d3f1435a348bece9e11787df982bd465db74ed8

commit r11-9248-g9d3f1435a348bece9e11787df982bd465db74ed8
Author: Jan Hubicka <jh@suse.cz>
Date:   Wed Nov 17 22:04:26 2021 +0100

    Fix modref summary streaming

    Fixes bug in streaming in modref access tree that now cause a failure
    of gamess benchmark.  The bug is quite old (present in GCC11 release) but
it
    needs quite interesting series of events to manifest. In particular
     1) At lto time ISRA turns some parameters passed by reference to scalar
     2) At lto time modref computes summaries for old parameters and then
updates
        them but does so quite stupidly believing that the load from parameters
        are now unkonwn loads (rather than optimized out).
        This renders summary not very useful since it thinks every memory
aliasing
        int is now accssed (as opposed as parameter dereference)
     3) At stream in we notice too early that summary is useless, set
every_access
        flag and drop the list.  However while reading rest of the summary we
        overwrite the flag back to 0 which makes us to lose part of summary.
     4) right selection of partitions needs to be done to avoid late modref
from
        recalculating and thus fixing the summary.

    This patch fixes the stream in bug, however we also should fix updating of
    summaries.

    gcc/ChangeLog:

    2021-11-17  Jan Hubicka  <hubicka@ucw.cz>

            PR ipa/103246
            * ipa-modref.c (read_modref_records): Fix streaminig in of
every_access
            flag.

    (cherry picked from commit 425369bf3068a9f840d1c2f04a4d4c38e924d4dc)

      parent reply	other threads:[~2021-11-18 19:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 10:22 [Bug ipa/103246] New: " marxin at gcc dot gnu.org
2021-11-15 10:24 ` [Bug ipa/103246] " marxin at gcc dot gnu.org
2021-11-15 10:39 ` marxin at gcc dot gnu.org
2021-11-15 10:39 ` marxin at gcc dot gnu.org
2021-11-15 10:40 ` marxin at gcc dot gnu.org
2021-11-15 10:40 ` marxin at gcc dot gnu.org
2021-11-15 11:13 ` hubicka at gcc dot gnu.org
2021-11-16 16:09 ` jamborm at gcc dot gnu.org
2021-11-16 17:09 ` jamborm at gcc dot gnu.org
2021-11-16 19:24 ` marxin at gcc dot gnu.org
2021-11-16 19:34 ` marxin at gcc dot gnu.org
2021-11-16 20:53 ` marxin at gcc dot gnu.org
2021-11-16 22:42 ` hubicka at gcc dot gnu.org
2021-11-17  0:44 ` cvs-commit at gcc dot gnu.org
2021-11-17  9:11 ` marxin at gcc dot gnu.org
2021-11-17  9:38 ` hubicka at kam dot mff.cuni.cz
2021-11-17 12:27 ` hubicka at gcc dot gnu.org
2021-11-17 13:03 ` hubicka at gcc dot gnu.org
2021-11-17 13:15 ` hubicka at gcc dot gnu.org
2021-11-17 13:31 ` hubicka at gcc dot gnu.org
2021-11-17 18:58 ` hubicka at gcc dot gnu.org
2021-11-17 19:36 ` hubicka at gcc dot gnu.org
2021-11-17 21:06 ` cvs-commit at gcc dot gnu.org
2021-11-18  8:27 ` hubicka at gcc dot gnu.org
2021-11-18  8:28 ` hubicka at gcc dot gnu.org
2021-11-18 12:22 ` marxin at gcc dot gnu.org
2021-11-18 19:10 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103246-4-hEFnjQYE1N@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).