public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103275] [11/12 Regression] don't generate kmov with IE model relocations
Date: Wed, 17 Nov 2021 13:19:29 +0000	[thread overview]
Message-ID: <bug-103275-4-Fhen22S8DS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103275-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103275

--- Comment #11 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Hongtao.liu from comment #10)
> I'm working on a patch which adds a new memory constraint "Bk" which will
> exclude TLS UNSPECs for mask register alternative.
> 
> The UNSPEC i'm excluding is like below, any other UNSPEC needs to be added?
> 
> bool
> ix86_notls_memory (rtx mem)
> {
>   gcc_assert (MEM_P (mem));
> 
>   rtx addr = XEXP (mem, 0);
>   subrtx_var_iterator::array_type array;
>   FOR_EACH_SUBRTX_VAR (iter, array, addr, ALL)
>     {
>       rtx op = *iter;
>       if (GET_CODE (op) == UNSPEC)
> 	switch (XINT (op, 1))
> 	  {
> 	  case UNSPEC_GOTTPOFF:
> 	  case UNSPEC_GOTNTPOFF:
> 	  case UNSPEC_TP:
> 	  case UNSPEC_TLS_GD:
> 	  case UNSPEC_TLS_LD_BASE:
> 	  case UNSPEC_TLSDESC:
> 	  case UNSPEC_TLS_IE_SUN:

This doesn't look right.  For TARGET_64BIT, only

        kmovq   foo@gottpoff(%rip), %k0
        kmovq   foo@tlsld(%rip), %k0

should be disallowed.  For !TARGET_64BIT, only

        kmovd   foo@gotntpoff(%eax), %k0
        kmovd   foo@tpoff(%eax), %k0

should be disallowed.

> 	    return false;
> 	  default:
> 	    break;
> 	  }
>       /* Should iter.skip_subrtxes ();
> 	 if there's no inner UNSPEC in addr???.  */
>     }
> 
>   return true;
> }

  parent reply	other threads:[~2021-11-17 13:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 13:55 [Bug c/103275] New: " jason at zx2c4 dot com
2021-11-16 14:02 ` [Bug target/103275] " pinskia at gcc dot gnu.org
2021-11-16 14:18 ` jason at zx2c4 dot com
2021-11-16 14:26 ` jason at zx2c4 dot com
2021-11-16 14:35 ` [Bug target/103275] [11 Regression] " jakub at gcc dot gnu.org
2021-11-16 14:51 ` pinskia at gcc dot gnu.org
2021-11-16 15:00 ` [Bug target/103275] [11/12 " rguenth at gcc dot gnu.org
2021-11-16 23:40 ` jason at zx2c4 dot com
2021-11-17  2:48 ` crazylht at gmail dot com
2021-11-17  3:09 ` hjl.tools at gmail dot com
2021-11-17  7:04 ` jakub at gcc dot gnu.org
2021-11-17 13:16 ` crazylht at gmail dot com
2021-11-17 13:19 ` hjl.tools at gmail dot com [this message]
2021-11-17 14:02 ` jason at zx2c4 dot com
2021-11-17 14:17 ` jakub at gcc dot gnu.org
2021-11-18  5:48 ` crazylht at gmail dot com
2021-11-22  3:36 ` cvs-commit at gcc dot gnu.org
2021-11-22  3:37 ` cvs-commit at gcc dot gnu.org
2021-11-22  3:39 ` crazylht at gmail dot com
2022-01-19 16:15 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103275-4-Fhen22S8DS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).