public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103281] [9/10/12 Regression] Dead Code Elimination Regression at -O3 (trunk vs 11.2.0)
Date: Tue, 16 Nov 2021 21:16:47 +0000	[thread overview]
Message-ID: <bug-103281-4-PUzaCMAeHh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103281-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103281

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #1)
> The only thing which PHIOPT does is change:
>   if (c_15 == 0)
>     goto <bb 4>; [INV]
>   else
>     goto <bb 5>; [INV]
> 
>   <bb 4> :
> 
>   <bb 5> :
>   # iftmp.1_10 = PHI <0(4), c_15(3)>
> 
> to be:
> iftmp.1_10 = c_15;
> 
> This is a missed VRP:
>   # RANGE [0, 2] NONZERO 3
>   c_9 = (charD.10) b.4_5;
>   _1 = c_9 <= 0;
>   # RANGE [0, 1] NONZERO 1
>   _2 = (unsigned intD.14) _1;
>   if (_2 == b.4_5)

Note it just happens that iftmp.1_10 case of being 0 is the only that matters
to be "peeled" off and special cased.

Plus it just happens:
    char a = c ? c : c << 1;

Is hiding the relationship between a and c.

GCC does optimize if we change the loop to:
b >= 1 && b < 4

What we need to realize is that 0 needs to "peeled" off and tried seperately
with the range. that is the following two ranges need to be done seperately for
b.4_5:
[0, 0] [1, 2]
But how do GCC decides that is "hard".
we know the range of _1 to be [0,1] so we need to figure out the ranges of c_9
which cause 0 and which one causes 1.  This is not just a forward looking
alogrothim but need to look back really. It can be very computational
instensive too.

  parent reply	other threads:[~2021-11-16 21:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 18:31 [Bug tree-optimization/103281] New: [12 " theodort at inf dot ethz.ch
2021-11-16 20:51 ` [Bug tree-optimization/103281] [9/12 " pinskia at gcc dot gnu.org
2021-11-16 20:52 ` [Bug tree-optimization/103281] [9/10/12 " pinskia at gcc dot gnu.org
2021-11-16 21:03 ` pinskia at gcc dot gnu.org
2021-11-16 21:16 ` pinskia at gcc dot gnu.org [this message]
2021-11-18 10:31 ` marxin at gcc dot gnu.org
2022-01-18 14:28 ` rguenth at gcc dot gnu.org
2022-05-27  9:46 ` [Bug tree-optimization/103281] [10/12/13 " rguenth at gcc dot gnu.org
2022-06-28 10:46 ` jakub at gcc dot gnu.org
2023-05-01 23:49 ` [Bug tree-optimization/103281] [10/12/13/14 " pinskia at gcc dot gnu.org
2023-08-07  5:47 ` [Bug tree-optimization/103281] [12/13/14 " pinskia at gcc dot gnu.org
2023-08-07  6:34 ` pinskia at gcc dot gnu.org
2023-08-07  6:34 ` pinskia at gcc dot gnu.org
2023-08-08 15:42 ` cvs-commit at gcc dot gnu.org
2023-08-08 15:43 ` pinskia at gcc dot gnu.org
2023-08-08 15:46 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103281-4-PUzaCMAeHh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).