From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7D7C2385C41B; Fri, 19 Nov 2021 18:16:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D7C2385C41B
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/103295] constexpr std::string does not work for clang
Date: Fri, 19 Nov 2021 18:16:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-103295-4-LBS7mWu5lv@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-103295-4@http.gcc.gnu.org/bugzilla/>
References: <bug-103295-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Nov 2021 18:16:30 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103295

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:2d76292bd6719d687bc77051da265df8ed7f5a61

commit r12-5413-g2d76292bd6719d687bc77051da265df8ed7f5a61
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 18 10:33:14 2021 +0000

    libstdc++: Begin lifetime of chars in constexpr std::string [PR103295]

    Clang gives errors for constexpr std::string because the memory returned
    by std::allocator<T>::allocate does not contain any objects yet, and
    attempting to set them using char_traits::assign or char_traits::copy
    fails with:

    assignment to object outside its lifetime is not allowed in a constant
expression
                  *__result =3D *__first;
                            ^
    This adds code to std::char_traits to use std::construct_at to begin
    lifetimes when called during constant evaluation. To support
    specializations of std::basic_string that don't use std::char_traits
    there is now another layer of wrapper around the allocator_traits, so
    that the lifetime of characters is begun as soon as the memory is
    allocated. By doing it in the char traits and allocator traits, the rest
    of basic_string can ignore the problem.

    While modifying char_traits::copy and char_traits::assign to begin
    lifetimes for the constexpr cases, I also replaced their uses of
    std::copy and std::fill_n respectively. That means we don't need
    <bits/stl_algobase.h> for char_traits.

    libstdc++-v3/ChangeLog:

            PR libstdc++/103295
            * include/bits/basic_string.h (_Alloc_traits): Replace typedef
            with struct for C++20 mode.
            * include/bits/basic_string.tcc (_M_replace): Use _Alloc_traits
            for allocation.
            * include/bits/char_traits.h (__gnu_cxx::char_traits::assign):
            Use std::_Construct during constant evaluation.
            (__gnu_cxx::char_traits::assign(CharT*, const CharT*, size_t)):
            Likewise. Replace std::fill_n with memset or manual loop.
            (__gnu_cxx::char_traits::copy): Likewise, replacing std::copy
            with memcpy.
            * include/ext/vstring.h: Include <bits/stl_algobase.h> for
            std::min.
            * include/std/string_view: Likewise.
            *
testsuite/21_strings/basic_string/capacity/char/resize_and_overwrite.cc:
            Add constexpr test.=