public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103353] Indefinite recursion when compiling -mmma requiring testcase w/ -maltivec
Date: Wed, 23 Feb 2022 02:38:33 +0000	[thread overview]
Message-ID: <bug-103353-4-mrUs5GpODU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103353-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103353

--- Comment #5 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #4)
> You miss all extra errors the expand_call can generate.  This is the general
> reason why we try to continue instead of stopping after the first error.  The
> reason is that later errors may be more obvious to the user.  This of course
> does no longer work so well because our errors now take 30 lines instead of
> 1.
> 

Thanks for the explanation! One consequent question is that this point can be
applied for the other places where some expected conditions don't hold for bif
expansion, but I saw the other places are using "return const0_rtx". Is there
something special causing this difference?

> It probably is best if the generic opaque-mode emit_move code does not try
> to move it via some other mode_class.  Peter?
> 
> Failing that, we can work around it by having move patterns for those modes
> always, but hard erroring on them (FAIL is no good).

Yeah, one workround can help the ICE gone: (similar thing needed for XOmode as
well):

diff --git a/gcc/config/rs6000/mma.md b/gcc/config/rs6000/mma.md
index 907c9d6d516..04e887ad147 100644
--- a/gcc/config/rs6000/mma.md
+++ b/gcc/config/rs6000/mma.md
@@ -268,10 +268,12 @@ (define_int_attr avvi4i4i4 [(UNSPEC_MMA_PMXVI8GER4PP     
 "pmxvi8ger4pp")
 (define_expand "movoo"
   [(set (match_operand:OO 0 "nonimmediate_operand")
         (match_operand:OO 1 "input_operand"))]
-  "TARGET_MMA"
+  ""
 {
-  rs6000_emit_move (operands[0], operands[1], OOmode);
-  DONE;
+  if (TARGET_MMA) {
+    rs6000_emit_move (operands[0], operands[1], OOmode);
+    DONE;
+  }
 })

 (define_insn_and_split "*movoo"

  parent reply	other threads:[~2022-02-23  2:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  2:09 [Bug target/103353] New: " asolokha at gmx dot com
2022-02-17  1:55 ` [Bug target/103353] " linkw at gcc dot gnu.org
2022-02-22  7:37 ` linkw at gcc dot gnu.org
2022-02-22  8:49 ` linkw at gcc dot gnu.org
2022-02-22 11:33 ` segher at gcc dot gnu.org
2022-02-23  2:38 ` linkw at gcc dot gnu.org [this message]
2022-02-24  4:32 ` asolokha at gmx dot com
2022-02-24 12:12 ` segher at gcc dot gnu.org
2022-08-16  5:50 ` cvs-commit at gcc dot gnu.org
2022-08-24  2:31 ` cvs-commit at gcc dot gnu.org
2022-08-24  2:32 ` cvs-commit at gcc dot gnu.org
2022-08-24  2:35 ` cvs-commit at gcc dot gnu.org
2022-08-24  2:49 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103353-4-mrUs5GpODU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).