public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "crazylht at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103393] [12 Regression] Generating 256bit register usage with -mprefer-avx128 -mprefer-vector-width=128
Date: Thu, 25 Nov 2021 01:15:43 +0000	[thread overview]
Message-ID: <bug-103393-4-dDLLjveIOF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103393-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103393

Hongtao.liu <crazylht at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crazylht at gmail dot com

--- Comment #5 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Richard Biener from comment #3)
> (In reply to H.J. Lu from comment #2)
> > (In reply to Richard Biener from comment #1)
> > > It isn't the vectorizer but memmove inline expansion.  I'm not sure it's
> > > really a bug, but there isn't a way to disable %ymm use besides disabling
> > > AVX entirely.
> > > HJ?
> > 
> > YMM move is generated by loop distribution which doesn't check
> > TARGET_PREFER_AVX128.
> 
> I think it's generated by gimple_fold_builtin_memory_op which since Richards
> changes accepts bigger now, up to MOVE_MAX * MOVE_RATIO and that ends up
> picking an integer mode via
> 
>               scalar_int_mode mode;
>               if (int_mode_for_size (ilen * 8, 0).exists (&mode)
>                   && GET_MODE_SIZE (mode) * BITS_PER_UNIT == ilen * 8
>                   && have_insn_for (SET, mode)
>                   /* If the destination pointer is not aligned we must be
> able
>                      to emit an unaligned store.  */
>                   && (dest_align >= GET_MODE_ALIGNMENT (mode)
>                       || !targetm.slow_unaligned_access (mode, dest_align)
>                       || (optab_handler (movmisalign_optab, mode)
>                           != CODE_FOR_nothing)))
> 
> not sure if there's another way to validate things.

For one single set operation, shouldn't the total size be less than MOVE_MAX
instead of MOVE_MAX * MOVE_RATIO?


      /* If we can perform the copy efficiently with first doing all loads and
         then all stores inline it that way.  Currently efficiently means that
         we can load all the memory with a single set operation and that the
         total size is less than MOVE_MAX * MOVE_RATIO.  */
      src_align = get_pointer_alignment (src);
      dest_align = get_pointer_alignment (dest);
      if (tree_fits_uhwi_p (len)
          && (compare_tree_int
              (len, (MOVE_MAX
                     * MOVE_RATIO (optimize_function_for_size_p (cfun))))
              <= 0)

  parent reply	other threads:[~2021-11-25  1:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 19:20 [Bug tree-optimization/103393] New: [ 12 Regression ] Auto vectorizer generating " jschoen4 at gmail dot com
2021-11-24  8:57 ` [Bug tree-optimization/103393] [12 Regression] Generating " rguenth at gcc dot gnu.org
2021-11-24 13:45 ` [Bug target/103393] " hjl.tools at gmail dot com
2021-11-24 13:53 ` rguenth at gcc dot gnu.org
2021-11-24 20:38 ` jschoen4 at gmail dot com
2021-11-25  1:15 ` crazylht at gmail dot com [this message]
2021-11-25  1:25 ` crazylht at gmail dot com
2021-11-25  7:16 ` rguenther at suse dot de
2021-11-25  7:28 ` [Bug middle-end/103393] " rguenth at gcc dot gnu.org
2021-11-25  7:40 ` rguenth at gcc dot gnu.org
2021-11-25 17:57 ` jakub at gcc dot gnu.org
2021-11-25 18:09 ` jakub at gcc dot gnu.org
2021-11-25 20:54 ` rearnsha at gcc dot gnu.org
2021-11-25 20:57 ` rearnsha at gcc dot gnu.org
2021-11-25 22:49 ` hjl.tools at gmail dot com
2021-11-26 11:31 ` rearnsha at gcc dot gnu.org
2021-11-26 11:37 ` jakub at gcc dot gnu.org
2021-11-26 11:44 ` rearnsha at gcc dot gnu.org
2021-11-26 11:48 ` jakub at gcc dot gnu.org
2021-11-26 11:51 ` rearnsha at gcc dot gnu.org
2021-11-26 11:58 ` jakub at gcc dot gnu.org
2021-11-26 12:26 ` rguenth at gcc dot gnu.org
2021-11-26 12:51 ` rearnsha at gcc dot gnu.org
2022-03-01 22:41 ` hjl.tools at gmail dot com
2022-03-02 14:52 ` hjl.tools at gmail dot com
2022-03-31  7:31 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103393-4-dDLLjveIOF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).