public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/103439] genemit emits dead code
Date: Fri, 26 Nov 2021 13:38:32 +0000 [thread overview]
Message-ID: <bug-103439-4-sjxuDXEvYj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103439-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103439
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Uroš Bizjak from comment #3)
> (In reply to rguenther@suse.de from comment #2)
> > On Fri, 26 Nov 2021, ubizjak at gmail dot com wrote:
> >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103439
> > >
> > > --- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
> > > (In reply to Richard Biener from comment #0)
> > > > I'm not sure if there are valid cases where we have a mix of a direct
> > > > RTL pattern and manual expansion, so where the { } part falls thru.
> > >
> > > Yes, we have quite some of them in e.g. i386.md, movstrict<mode>, extv<mode>,
> > > extzv<mode>, insv<mode> and zero_extend expanders are some of them.
> >
> > OK, so that's conditional FAILs. I've not yet found a conditional
> > DONE that eventually falls through to a "DONE via the pattern".
>
> Look at zero_extend and extend expanders.
Indeed.
(define_expand "zero_extendqihi2"
[(set (match_operand:HI 0 "register_operand")
(zero_extend:HI (match_operand:QI 1 "nonimmediate_operand")))]
""
{
if (TARGET_ZERO_EXTEND_WITH_AND && optimize_function_for_speed_p (cfun))
{
operands[1] = force_reg (QImode, operands[1]);
emit_insn (gen_zero_extendqihi2_and (operands[0], operands[1]));
DONE;
}
})
and
/* /home/rguenther/src/trunk/gcc/config/i386/i386.md:4120 */
rtx
gen_zero_extendqihi2 (rtx operand0,
rtx operand1)
{
rtx_insn *_val = 0;
start_sequence ();
{
rtx operands[2];
operands[0] = operand0;
operands[1] = operand1;
#define FAIL return (end_sequence (), _val)
#define DONE return (_val = get_insns (), end_sequence (), _val)
#line 4124 "/home/rguenther/src/trunk/gcc/config/i386/i386.md"
{
if (TARGET_ZERO_EXTEND_WITH_AND && optimize_function_for_speed_p (cfun))
{
operands[1] = force_reg (QImode, operands[1]);
emit_insn (gen_zero_extendqihi2_and (operands[0], operands[1]));
DONE;
}
}
#undef DONE
#undef FAIL
operand0 = operands[0];
(void) operand0;
operand1 = operands[1];
(void) operand1;
}
emit_insn (gen_rtx_SET (operand0,
gen_rtx_ZERO_EXTEND (HImode,
operand1)));
_val = get_insns ();
end_sequence ();
return _val;
}
so quite hard if not impossible to "fix" in genemit
next prev parent reply other threads:[~2021-11-26 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 12:10 [Bug middle-end/103439] New: " rguenth at gcc dot gnu.org
2021-11-26 12:26 ` [Bug middle-end/103439] " ubizjak at gmail dot com
2021-11-26 12:28 ` rguenther at suse dot de
2021-11-26 13:11 ` ubizjak at gmail dot com
2021-11-26 13:38 ` rguenth at gcc dot gnu.org [this message]
2021-11-26 22:06 ` pinskia at gcc dot gnu.org
2021-11-29 7:21 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-103439-4-sjxuDXEvYj@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).