* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
@ 2021-11-29 7:37 ` pinskia at gcc dot gnu.org
2021-11-29 7:43 ` crazylht at gmail dot com
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-29 7:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
2021-11-29 7:37 ` [Bug target/103463] " pinskia at gcc dot gnu.org
@ 2021-11-29 7:43 ` crazylht at gmail dot com
2021-11-29 8:58 ` marxin at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: crazylht at gmail dot com @ 2021-11-29 7:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
Hongtao.liu <crazylht at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |crazylht at gmail dot com
--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
It should be fixed by
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585613.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
2021-11-29 7:37 ` [Bug target/103463] " pinskia at gcc dot gnu.org
2021-11-29 7:43 ` crazylht at gmail dot com
@ 2021-11-29 8:58 ` marxin at gcc dot gnu.org
2021-11-29 9:46 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-29 8:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-11-29
CC| |marxin at gcc dot gnu.org
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Assignee|unassigned at gcc dot gnu.org |crazylht at gmail dot com
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (2 preceding siblings ...)
2021-11-29 8:58 ` marxin at gcc dot gnu.org
@ 2021-11-29 9:46 ` cvs-commit at gcc dot gnu.org
2021-11-30 7:44 ` crazylht at gmail dot com
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-29 9:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:
https://gcc.gnu.org/g:9519b694afbf9a35c36cf9f14d35d1c0e9e8cacc
commit r12-5573-g9519b694afbf9a35c36cf9f14d35d1c0e9e8cacc
Author: liuhongt <hongtao.liu@intel.com>
Date: Fri Nov 26 23:24:20 2021 +0800
Fix regression introduced by r12-5536.
There're several failures:
1. unsupported instruction `pextrw` for "pextrw $0, %xmm31, 16(%rax)"
%vpextrw should be used in output templates.
2. ICE in get_attr_memory for movhi_internal since some alternatives
are marked as TYPE_SSELOG.
use TYPE_SSELOG1 instead.
Also this patch fixs a typo and some latent bugs which are related to
moving HImode from/to sse register w/o TARGET_AVX512FP16.
gcc/ChangeLog:
PR target/102811
PR target/103463
* config/i386/i386.c (ix86_secondary_reload): Without
TARGET_SSE4_1, General register is needed to move HImode from
sse register to memory.
* config/i386/sse.md (*vec_extrachf): Use %vpextrw instead of
pextrw in output templates.
* config/i386/i386.md (movhi_internal): Ditto, also fix typo of
MEM_P (operands[1]) and adjust mode/prefix/type attribute for
alternatives related to sse register.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (3 preceding siblings ...)
2021-11-29 9:46 ` cvs-commit at gcc dot gnu.org
@ 2021-11-30 7:44 ` crazylht at gmail dot com
2021-11-30 7:58 ` crazylht at gmail dot com
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: crazylht at gmail dot com @ 2021-11-30 7:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #1)
> It should be fixed by
> https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585613.html
Hmm, it looks to be broken again.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (4 preceding siblings ...)
2021-11-30 7:44 ` crazylht at gmail dot com
@ 2021-11-30 7:58 ` crazylht at gmail dot com
2021-11-30 8:19 ` crazylht at gmail dot com
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: crazylht at gmail dot com @ 2021-11-30 7:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #4 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #3)
> (In reply to Hongtao.liu from comment #1)
> > It should be fixed by
> > https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585613.html
>
> Hmm, it looks to be broken again.
I thought is was same problem as
https://gcc.gnu.org/pipermail/gcc-regression/2021-November/075893.html, but
it's not.
It's caused by r12-5558
the insn hit gcc_assert in ix86_attr_length_immediate_default is
(insn 20 19 21 2 (parallel [
(set (reg:DI 1 dx [orig:110 bar0_u128_0 ] [110])
(ior:DI (lshiftrt:DI (reg:DI 1 dx [orig:110 bar0_u128_0 ]
[110])
(const_int 0 [0]))
(subreg:DI (ashift:TI (zero_extend:TI (reg:DI 0 ax
[orig:111+8 ] [111]))
(const_int 64 [0x40])) 0)))
(clobber (reg:CC 17 flags))
which set len = 1 and hit gcc_assert (!len);
if (IN_RANGE (ival, -128, 127))
{
len = 1;
continue;
}
}
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (5 preceding siblings ...)
2021-11-30 7:58 ` crazylht at gmail dot com
@ 2021-11-30 8:19 ` crazylht at gmail dot com
2021-11-30 23:39 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: crazylht at gmail dot com @ 2021-11-30 8:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #5 from Hongtao.liu <crazylht at gmail dot com> ---
diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index c88374c9d2b..4e9fae80479 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -11512,6 +11512,7 @@ (define_insn "*x86_64_shld_1"
[(set_attr "type" "ishift")
(set_attr "prefix_0f" "1")
(set_attr "mode" "DI")
+ (set_attr "length_immediate" "1")
(set_attr "athlon_decode" "vector")
(set_attr "amdfam10_decode" "vector")
(set_attr "bdver1_decode" "vector")])
@@ -11573,6 +11574,7 @@ (define_insn "*x86_shld_1"
"shld{l}\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "type" "ishift")
(set_attr "prefix_0f" "1")
+ (set_attr "length_immediate" "1")
(set_attr "mode" "SI")
(set_attr "pent_pair" "np")
(set_attr "athlon_decode" "vector")
@@ -12384,6 +12386,7 @@ (define_insn "*x86_64_shrd_1"
"shrd{q}\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "type" "ishift")
(set_attr "prefix_0f" "1")
+ (set_attr "length_immediate" "1")
(set_attr "mode" "DI")
(set_attr "athlon_decode" "vector")
(set_attr "amdfam10_decode" "vector")
@@ -12446,6 +12449,7 @@ (define_insn "*x86_shrd_1"
"shrd{l}\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "type" "ishift")
(set_attr "prefix_0f" "1")
+ (set_attr "length_immediate" "1")
(set_attr "mode" "SI")
(set_attr "pent_pair" "np")
(set_attr "athlon_decode" "vector")
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (6 preceding siblings ...)
2021-11-30 8:19 ` crazylht at gmail dot com
@ 2021-11-30 23:39 ` cvs-commit at gcc dot gnu.org
2021-12-01 0:51 ` crazylht at gmail dot com
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-30 23:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:
https://gcc.gnu.org/g:f5e2f2d0ad1b293c534338a72094926313e12039
commit r12-5647-gf5e2f2d0ad1b293c534338a72094926313e12039
Author: liuhongt <hongtao.liu@intel.com>
Date: Tue Nov 30 16:24:39 2021 +0800
Fix ICE in ix86_attr_length_immediate_default.
ix86_attr_length_immediate_default assume TYPE ishift only have 1
constant operand,
but *x86_64_shld_1/*x86_shld_1/*x86_64_shrd_1/*x86_shrd_1 has 2, with
condition: INTVAL (operands[3]) == 32 - INTVAL (operands[2]) or
INTVAL (operands[3]) == 64 - INTVAL (operands[2]), and hit
gcc_assert.
Explicitly set_attr length_immediate for these patterns.
gcc/ChangeLog:
PR target/103463
PR target/103484
* config/i386/i386.md (*x86_64_shld_1): Set_attr
length_immediate to 1.
(*x86_shld_1): Ditto.
(*x86_64_shrd_1): Ditto.
(*x86_shrd_1): Ditto.
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr103463.c: New test.
* gcc.target/i386/pr103463-2.c: New test.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (7 preceding siblings ...)
2021-11-30 23:39 ` cvs-commit at gcc dot gnu.org
@ 2021-12-01 0:51 ` crazylht at gmail dot com
2021-12-03 10:14 ` pinskia at gcc dot gnu.org
2021-12-04 21:44 ` pinskia at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: crazylht at gmail dot com @ 2021-12-01 0:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
Hongtao.liu <crazylht at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Hongtao.liu <crazylht at gmail dot com> ---
Really fixed in GCC12.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (8 preceding siblings ...)
2021-12-01 0:51 ` crazylht at gmail dot com
@ 2021-12-03 10:14 ` pinskia at gcc dot gnu.org
2021-12-04 21:44 ` pinskia at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-03 10:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 103450 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/103463] [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp
2021-11-29 7:22 [Bug target/103463] New: [12 Regression] ICE: in ix86_attr_length_immediate_default, at config/i386/i386.c:16686 with -Os -fno-tree-dominator-opts -fno-tree-vrp zsojka at seznam dot cz
` (9 preceding siblings ...)
2021-12-03 10:14 ` pinskia at gcc dot gnu.org
@ 2021-12-04 21:44 ` pinskia at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-04 21:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103463
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |slyfox at gcc dot gnu.org
--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 103557 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 12+ messages in thread