public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103515] Unexpected OPTION_MASK_SAVE_TOC_INDIRECT of rs6000_isa_flag
Date: Mon, 13 Dec 2021 06:22:07 +0000	[thread overview]
Message-ID: <bug-103515-4-5foZqV0QgA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103515-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103515

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:01ad8c54fdca1db3d71bf6c4b861a9d1db3c2a59

commit r12-5920-g01ad8c54fdca1db3d71bf6c4b861a9d1db3c2a59
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Sun Dec 12 23:27:51 2021 -0600

    pragma: Update target option node when optimization changes [PR103515]

    For a function with optimize pragma, it's possible that the target
    options change as optimization options change.  Now we create one
    optimization option node when optimize pragma parsing, but don't
    create target option node for possible target option changes.  It
    makes later processing not detect the target options can actually
    change and further doesn't update the target options accordingly.

    This patch is to check whether target options have changed when
    creating one optimization option node for pragma optimize, and
    make one target option node if needed.  The associated test case
    shows the difference.  Without this patch, the function foo1 will
    perform unrolling which is unexpected.  The reason is that flag
    unroll_only_small_loops isn't correctly set for it.  The value
    is updated after parsing function foo2, but doesn't get restored
    later since both decls don't have DECL_FUNCTION_SPECIFIC_TARGET
    set and the hook thinks we don't need to switch.  With this patch,
    there is no unrolling for foo1, which is also consistent with the
    behavior by replacing pragma by attribute whether w/ and w/o this
    patch.

    As Martin noted, this change does the similar thing like what his
    previous commit r12-1039 did.

    gcc/ChangeLog:

            PR target/103515
            * attribs.c (decl_attributes): Check if target options change and
            create one node if so.

    gcc/testsuite/ChangeLog:

            PR target/103515
            * gcc.target/powerpc/pr103515.c: New test.

  parent reply	other threads:[~2021-12-13  6:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  8:19 [Bug target/103515] New: " linkw at gcc dot gnu.org
2021-12-01  8:29 ` [Bug target/103515] " linkw at gcc dot gnu.org
2021-12-01  9:31 ` marxin at gcc dot gnu.org
2021-12-02  1:43 ` linkw at gcc dot gnu.org
2021-12-02  1:45 ` linkw at gcc dot gnu.org
2021-12-13  6:22 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-19 21:46 ` bergner at gcc dot gnu.org
2022-05-20  2:06 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103515-4-5foZqV0QgA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).