public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vmakarov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/103541] unnecessary spills around const functions calls
Date: Fri, 03 Feb 2023 23:15:38 +0000	[thread overview]
Message-ID: <bug-103541-4-WkbLB983YV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103541-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103541

Vladimir Makarov <vmakarov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at gcc dot gnu.org

--- Comment #4 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Honza, thank you for reporting this.  Fixing just the following code will not
solve the problem as LRA uses only equiv expression valid for the whole
function.

>           ret = valid_combine;
>           if (!MEM_READONLY_P (memref)
>               && !RTL_CONST_OR_PURE_CALL_P (insn))
>             return valid_none;
> 

By the way, the old reload pass still works on the test and producing the same
code as LRA currently, also reserving stack slot and using it around the call
instead of reload from a.

I've been working on this problem and I hope the fix will be ready on the next
week.

  parent reply	other threads:[~2023-02-03 23:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 15:16 [Bug rtl-optimization/103541] New: " hubicka at gcc dot gnu.org
2021-12-03 20:35 ` [Bug rtl-optimization/103541] " pinskia at gcc dot gnu.org
2021-12-03 20:35 ` pinskia at gcc dot gnu.org
2021-12-03 20:37 ` pinskia at gcc dot gnu.org
2023-02-03 23:15 ` vmakarov at gcc dot gnu.org [this message]
2023-02-07 14:05 ` cvs-commit at gcc dot gnu.org
2023-02-08 22:30 ` hjl.tools at gmail dot com
2023-02-09 21:48 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103541-4-WkbLB983YV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).