[Bug fortran/103609] New: [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243

[Bug fortran/103609] New: [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

            Bug ID: 103609
           Summary: [11/12 Regression] ICE in gfc_sym_get_dummy_args, at
                    fortran/symbol.c:5243
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200726 and 20200809 :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
program p
   implicit none
   integer :: i
   do i = 1, 2
      call s
   end do
contains
   subroutine s
      integer :: n
      call n
   end
end


$ gfortran-12-20211205 -c z1.f90
z1.f90:9:18:

    9 |       integer :: n
      |                  1
   10 |       call n
      |            2
Error: 'n' at (1) has a type, which is not consistent with the CALL at (2)
f951: internal compiler error: Segmentation fault
0xf0b99f crash_signal
        ../../gcc/toplev.c:322
0x87f8f0 gfc_sym_get_dummy_args(gfc_symbol*)
        ../../gcc/fortran/symbol.c:5243
0x94ec51 doloop_contained_procedure_code
        ../../gcc/fortran/frontend-passes.c:2483
0x954519 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5333
0x956a32 doloop_code
        ../../gcc/fortran/frontend-passes.c:2627
0x954519 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5333
0x954697 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5669
0x95570b doloop_warn
        ../../gcc/fortran/frontend-passes.c:3059
0x955c5a gfc_run_passes(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.c:156
0x856467 gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17572
0x83e764 resolve_all_program_units
        ../../gcc/fortran/parse.c:6586
0x83e764 gfc_parse_file()
        ../../gcc/fortran/parse.c:6842
0x88c73f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

Seems to be related :


$ cat z2.f90
program p
   implicit none
   integer :: i
   do i = 1, 2
      call s
   end do
contains
   subroutine s
      call sub(x)
   end
end


$ gfortran-12-20211205 -c z2.f90
z2.f90:9:16:

    9 |       call sub(x)
      |                1
Error: Symbol 'x' at (1) has no IMPLICIT type
f951: internal compiler error: Segmentation fault
0xf0b99f crash_signal
        ../../gcc/toplev.c:322
0x87f8f0 gfc_sym_get_dummy_args(gfc_symbol*)
        ../../gcc/fortran/symbol.c:5243
0x94ec51 doloop_contained_procedure_code
        ../../gcc/fortran/frontend-passes.c:2483
0x954519 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5333
0x956a32 doloop_code
        ../../gcc/fortran/frontend-passes.c:2627
0x954519 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5333
0x954697 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5669
0x95570b doloop_warn
        ../../gcc/fortran/frontend-passes.c:3059
0x955c5a gfc_run_passes(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.c:156
0x856467 gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17572
0x83e764 resolve_all_program_units
        ../../gcc/fortran/parse.c:6586
0x83e764 gfc_parse_file()
        ../../gcc/fortran/parse.c:6842
0x88c73f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.3

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |tkoenig at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-12-08
             Status|UNCONFIRMED                 |NEW
            Summary|[11/12 Regression] ICE in   |[11/12 Regression] ICE in
                   |gfc_sym_get_dummy_args, at  |gfc_sym_get_dummy_args, at
                   |fortran/symbol.c:5243       |fortran/symbol.c:5243 since
                   |                            |r11-2578-g27eac9ee6137a6b5

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-2578-g27eac9ee6137a6b5.

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
Testing obvious fix for NULL pointer dereference:

diff --git a/gcc/fortran/symbol.c b/gcc/fortran/symbol.c
index 179f6029ca3..ebd99846610 100644
--- a/gcc/fortran/symbol.c
+++ b/gcc/fortran/symbol.c
@@ -5240,6 +5240,9 @@ gfc_sym_get_dummy_args (gfc_symbol *sym)
 {
   gfc_formal_arglist *dummies;

+  if (sym == NULL)
+    return NULL;
+
   dummies = sym->formal;
   if (dummies == NULL && sym->ts.interface != NULL)
     dummies = sym->ts.interface->formal;

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:b77968a70537429b4f548f90c369d26e6b6943cc

commit r12-5847-gb77968a70537429b4f548f90c369d26e6b6943cc
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Dec 8 21:14:19 2021 +0100

    Fortran: avoid NULL pointer dereference on missing or bad dummy arguments

    gcc/fortran/ChangeLog:

            PR fortran/103609
            * symbol.c (gfc_sym_get_dummy_args): Catch NULL pointer
            dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/103609
            * gfortran.dg/pr103609.f90: New test.

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:81ffb19017daf7197445ed0793e925674a3970d5

commit r11-9368-g81ffb19017daf7197445ed0793e925674a3970d5
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Dec 8 21:14:19 2021 +0100

    Fortran: avoid NULL pointer dereference on missing or bad dummy arguments

    gcc/fortran/ChangeLog:

            PR fortran/103609
            * symbol.c (gfc_sym_get_dummy_args): Catch NULL pointer
            dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/103609
            * gfortran.dg/pr103609.f90: New test.

    (cherry picked from commit b77968a70537429b4f548f90c369d26e6b6943cc)

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12, and on 11-branch.  Closing.

Thanks for the report!

[Bug fortran/103609] [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 since r11-2578-g27eac9ee6137a6b5

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103609

--- Comment #7 from G. Steinmetz <gscfq@t-online.de> ---
Thank you for fixing this issue !