public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mathieu.malaterre at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/103629] Possible miscompilation triggered by -fvisibility=hidden
Date: Thu, 09 Dec 2021 14:23:07 +0000	[thread overview]
Message-ID: <bug-103629-4-vr1PNzPbPf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103629-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103629

--- Comment #7 from Mathieu Malaterre <mathieu.malaterre at gmail dot com> ---
(In reply to Andrew Pinski from comment #6)
> (In reply to Mathieu Malaterre from comment #5)
> > (In reply to Andrew Pinski from comment #4)
> > > (In reply to Mathieu Malaterre from comment #3)
> > > > $ export CXXFLAGS=-fvisibility=hidden
> > > 
> > > Yes you can't just use -fvisibility=hidden without the source being ready
> > > for it.
> > 
> > Andrew, could you please be a bit more specific. I do not see any changes
> > related to duplicate `typeinfo` or `visibility=hidden` in the changelog:
> > 
> > * https://gcc.gnu.org/gcc-11/changes.html
> 
> right there has been no major changes in this area as far as I Know. 
> 
> > 
> > `-fvisibility=hidden` was added in 2015 in the Debian/OpenVDB package and
> > has worked quite well for all users so far. It would be nice if gcc/ld would
> > help track any `type_info` issue, in large portable c++ codebase.
> 
> It was working by accident before. Do you know why it was added? Has the
> code upstream in OpenVDB been fixed for adding the visibility attribute
> where needed?

OpenVDB is supposed to be /portable/ c++. The dll export mechanism has been
working on windows arch since basically day-one.

The gcc implementation is at:

*
https://github.com/AcademySoftwareFoundation/openvdb/blob/master/openvdb/openvdb/Platform.h#L218-L219

IMHO this is following the wiki from:

* https://gcc.gnu.org/wiki/Visibility

  parent reply	other threads:[~2021-12-09 14:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 13:25 [Bug c++/103629] New: " mathieu.malaterre at gmail dot com
2021-12-09 13:30 ` [Bug c++/103629] " marxin at gcc dot gnu.org
2021-12-09 13:32 ` pinskia at gcc dot gnu.org
2021-12-09 13:38 ` mathieu.malaterre at gmail dot com
2021-12-09 13:45 ` pinskia at gcc dot gnu.org
2021-12-09 14:03 ` mathieu.malaterre at gmail dot com
2021-12-09 14:15 ` pinskia at gcc dot gnu.org
2021-12-09 14:23 ` mathieu.malaterre at gmail dot com [this message]
2021-12-10 13:11 ` mathieu.malaterre at gmail dot com
2021-12-10 13:13 ` [Bug c++/103629] Possible miscompilation triggered by pthread + exception mathieu.malaterre at gmail dot com
2021-12-10 13:20 ` [Bug c++/103629] Possible miscompilation visible using " pinskia at gcc dot gnu.org
2021-12-10 13:22 ` [Bug libstdc++/103629] " pinskia at gcc dot gnu.org
2021-12-10 14:33 ` redi at gcc dot gnu.org
2021-12-10 15:01 ` redi at gcc dot gnu.org
2021-12-10 15:09 ` redi at gcc dot gnu.org
2021-12-10 15:10 ` redi at gcc dot gnu.org
2021-12-10 15:13 ` redi at gcc dot gnu.org
2021-12-10 15:28 ` redi at gcc dot gnu.org
2021-12-19 22:52 ` pinskia at gcc dot gnu.org
2021-12-19 22:53 ` [Bug libstdc++/103629] [11/12 Regression] " pinskia at gcc dot gnu.org
2022-01-04  9:04 ` rguenth at gcc dot gnu.org
2022-04-21  7:50 ` rguenth at gcc dot gnu.org
2022-08-24 12:14 ` [Bug libstdc++/103629] [11/12/13 " malat at debian dot org
2022-08-24 12:14 ` malat at debian dot org
2022-08-24 12:16 ` malat at debian dot org
2022-08-24 12:28 ` [Bug libstdc++/103629] [11/12/13 Regression] wrong-code when mixing mutex with visibility=hidden malat at debian dot org
2022-08-24 12:30 ` malat at debian dot org
2023-03-17  7:36 ` malat at debian dot org
2023-05-29 10:06 ` [Bug libstdc++/103629] [11/12/13/14 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103629-4-vr1PNzPbPf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).