public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c
Date: Thu, 27 Jan 2022 10:35:58 +0000	[thread overview]
Message-ID: <bug-103642-4-BHBMlSaDMX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103642-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Chung-Lin Tang <cltang@gcc.gnu.org>:

https://gcc.gnu.org/g:1c91b014923f418e0aab789c5cf57facf04bf266

commit r12-6890-g1c91b014923f418e0aab789c5cf57facf04bf266
Author: Chung-Lin Tang <cltang@codesourcery.com>
Date:   Thu Jan 27 18:33:00 2022 +0800

    Fix omp-low ICE for indirect references based off component access
[PR103642]

    This issue was triggered after the patch extending syntax for component
access
    in map clauses in commit 0ab29cf0bb68960c1f87405f14b4fb2109254e2f.

    In gimplify_scan_omp_clauses, the case for handling indirect accesses
(which
    creates firstprivate ptr and zero-length array section map for such decls)
was
    erroneously went into for non-pointer cases (here being the base struct
decl),
    so added the
    appropriate checks there.

    Added new testcase is a compile only test for the ICE. The original
omptests
    t-partial-struct test actually should not execute correctly, because for
    map(t.s->a[:N]), map(t.s[:1]) is not implicitly mapped, thus the entire
    offloaded access does not work as is (fixing that omptests test is out of
    scope here).

    2022-01-27  Chung-Lin Tang  <cltang@codesourcery.com>

            PR middle-end/103642

    gcc/ChangeLog:

            * gimplify.cc (gimplify_scan_omp_clauses): Do not do indir_p
handling
            for non-pointer or non-reference-to-pointer cases.

    gcc/testsuite/ChangeLog:

            * c-c++-common/gomp/pr103642.c: New test.

  parent reply	other threads:[~2022-01-27 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  9:41 [Bug middle-end/103642] New: [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) burnus at gcc dot gnu.org
2021-12-10 10:08 ` [Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c marxin at gcc dot gnu.org
2021-12-28 12:10 ` pinskia at gcc dot gnu.org
2022-01-17 12:49 ` rguenth at gcc dot gnu.org
2022-01-19 16:34 ` burnus at gcc dot gnu.org
2022-01-27 10:35 ` cvs-commit at gcc dot gnu.org [this message]
2022-02-04 14:28 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103642-4-BHBMlSaDMX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).