public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103676] [10/11/12 Regression] internal compiler error: in extract_constrain_insn, at recog.c:2671
Date: Fri, 21 Jan 2022 18:37:55 +0000	[thread overview]
Message-ID: <bug-103676-4-CowED9yUwg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103676-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103676

--- Comment #24 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:85419ac59724b7ce710ebb4acf03dbd747edeea3

commit r12-6803-g85419ac59724b7ce710ebb4acf03dbd747edeea3
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Fri Jan 21 13:34:32 2022 -0500

    [PR103676] LRA: Calculate and exclude some start hard registers for reload
pseudos

    LRA and old reload pass uses only one register class for reload pseudos
even if
    operand constraints contain more one register class.  Let us consider
    constraint 'lh' for thumb arm which means low and high thumb registers.
    Reload pseudo for such constraint will have general reg class (union of
    low and high reg classes).  Assigning the last low register to the reload
    pseudo is wrong if the pseudo is of DImode as it requires two hard regs.
    But it is considered OK if we use general reg class.  The following patch
    solves this problem for LRA.

    gcc/ChangeLog:

            PR target/103676
            * ira.h (struct target_ira): Add member
            x_ira_exclude_class_mode_regs.
            (ira_exclude_class_mode_regs): New macro.
            * lra.h (lra_create_new_reg): Add arg exclude_start_hard_regs and
            move from here ...
            * lra-int.h: ... to here.
            (lra_create_new_reg_with_unique_value): Add arg
            exclude_start_hard_regs.
            (class lra_reg): Add member exclude_start_hard_regs.
            * lra-assigns.cc (find_hard_regno_for_1): Setup
            impossible_start_hard_regs from exclude_start_hard_regs.
            * lra-constraints.cc (get_reload_reg): Add arg
exclude_start_hard_regs and pass
            it lra_create_new_reg[_with_unique_value].
            (match_reload): Ditto.
            (check_and_process_move): Pass NULL
            exclude_start_hard_regs to lra_create_new_reg_with_unique_value.
            (goal_alt_exclude_start_hard_regs): New static variable.
            (process_addr_reg, simplify_operand_subreg): Pass NULL
            exclude_start_hard_regs to lra_create_new_reg_with_unique_value
            and get_reload_reg.
            (process_alt_operands): Setup goal_alt_exclude_start_hard_regs.
            Use this_alternative_exclude_start_hard_regs additionally to find
            winning operand alternative.
            (base_to_reg, base_plus_disp_to_reg, index_part_to_reg): Pass NULL
            exclude_start_hard_regs to lra_create_new_reg.
            (process_address_1, emit_inc): Ditto.
            (curr_insn_transform): Pass exclude_start_hard_regs value to
            lra_create_new_reg, get_reload_reg, match_reload.
            (inherit_reload_reg, split_reg): Pass NULL exclude_start_hard_regs
            to lra_create_new_reg.
            (process_invariant_for_inheritance): Ditto.
            * lra-remat.cc (update_scratch_ops): Ditto.
            * lra.cc (lra_create_new_reg_with_unique_value): Add arg
            exclude_start_hard_regs.  Setup the corresponding member of
            lra reg info.
            (lra_create_new_reg): Add arg exclude_start_hard_regs and pass it
            to lra_create_new_reg_with_unique_value.
            (initialize_lra_reg_info_element): Initialize member
            exclude_start_hard_regs.
            (get_scratch_reg): Pass NULL to lra_create_new_reg.
            * ira.cc (setup_prohibited_class_mode_regs): Rename to
            setup_prohibited_and_exclude_class_mode_regs and calculate
            ira_exclude_class_mode_regs.

    gcc/testsuite/ChangeLog:

            PR target/103676
            * g++.target/arm/pr103676.C: New.

  parent reply	other threads:[~2022-01-21 18:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-12 22:32 [Bug target/103676] New: " patrick.oppenlander at gmail dot com
2021-12-12 23:31 ` [Bug target/103676] " pinskia at gcc dot gnu.org
2021-12-12 23:32 ` pinskia at gcc dot gnu.org
2021-12-12 23:54 ` patrick.oppenlander at gmail dot com
2021-12-12 23:58 ` patrick.oppenlander at gmail dot com
2021-12-13 22:56 ` patrick.oppenlander at gmail dot com
2021-12-13 23:06 ` pinskia at gcc dot gnu.org
2021-12-13 23:13 ` pinskia at gcc dot gnu.org
2021-12-14  0:48 ` patrick.oppenlander at gmail dot com
2021-12-14  0:48 ` patrick.oppenlander at gmail dot com
2021-12-14  0:51 ` pinskia at gcc dot gnu.org
2021-12-14  0:52 ` pinskia at gcc dot gnu.org
2021-12-14  1:16 ` patrick.oppenlander at gmail dot com
2021-12-14  1:17 ` patrick.oppenlander at gmail dot com
2021-12-14  1:48 ` pinskia at gcc dot gnu.org
2021-12-14  1:50 ` [Bug target/103676] [10/11/12 Regression] " pinskia at gcc dot gnu.org
2021-12-14  2:07 ` pinskia at gcc dot gnu.org
2021-12-14  2:11 ` pinskia at gcc dot gnu.org
2021-12-14  2:15 ` pinskia at gcc dot gnu.org
2021-12-29 17:02 ` jakub at gcc dot gnu.org
2021-12-29 17:06 ` jakub at gcc dot gnu.org
2022-01-17 12:46 ` rguenth at gcc dot gnu.org
2022-01-17 16:43 ` vmakarov at gcc dot gnu.org
2022-01-17 17:00 ` jakub at gcc dot gnu.org
2022-01-18 13:38 ` vmakarov at gcc dot gnu.org
2022-01-21 18:37 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-28 16:38 ` [Bug target/103676] [10/11 " jakub at gcc dot gnu.org
2022-06-28 10:47 ` jakub at gcc dot gnu.org
2023-07-07 10:41 ` [Bug target/103676] [11 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103676-4-CowED9yUwg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).