public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/103691] [12 Regression] ICE in get_array_ctor_element_at_index, at fold-const.c:13314 since r12-4694-gcb153222404e2e14
Date: Wed, 05 Jan 2022 09:46:03 +0000	[thread overview]
Message-ID: <bug-103691-4-vu4haWkrAm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103691-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103691

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a4c2e62d60f47d47cdd94951e16b0de50495cdab

commit r12-6221-ga4c2e62d60f47d47cdd94951e16b0de50495cdab
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 5 10:45:26 2022 +0100

    gimple-fold: Remove incorrect folding of debug stmts [PR103691]

    For ADDR_EXPR gimple_debug_bind_get_value fold_stmt_1 uses
    maybe_canonicalize_mem_ref_addr earlier and I think that should
    resolve the concerns raised in PR52329.  But folding ADDR_EXPR
    operand using maybe_fold_reference and then taking address of that
    looks like an invalid transformation, it can transform
      # DEBUG D.4293 => &a[0]
    into
      # DEBUG D.4293 => &2.0e+0
    etc., all we want to allow are the lhs folding of the operand which
    maybe_fold_reference no longer does since r12-21-g0bf8cd9d5e8ac.

    2022-01-05  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/103691
            * gimple-fold.c (fold_stmt_1): Don't call maybe_fold_reference
            for DEBUG stmts with ADDR_EXPR gimple_debug_bind_get_value,
            it can do unwanted rhs folding like &a[0] into &2.0 etc.

            * gfortran.dg/pr103691.f90: New test.

  parent reply	other threads:[~2022-01-05  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 19:51 [Bug fortran/103691] New: [12 Regression] ICE in get_array_ctor_element_at_index, at fold-const.c:13314 gscfq@t-online.de
2021-12-14 10:05 ` [Bug fortran/103691] [12 Regression] ICE in get_array_ctor_element_at_index, at fold-const.c:13314 since r12-4694-gcb153222404e2e14 marxin at gcc dot gnu.org
2021-12-14 15:43 ` amacleod at redhat dot com
2022-01-04 11:07 ` rguenth at gcc dot gnu.org
2022-01-04 11:32 ` jakub at gcc dot gnu.org
2022-01-04 12:26 ` rguenth at gcc dot gnu.org
2022-01-04 12:28 ` jakub at gcc dot gnu.org
2022-01-05  9:46 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-05  9:49 ` jakub at gcc dot gnu.org
2022-03-24 15:23 ` jakub at gcc dot gnu.org
2022-03-25 10:23 ` cvs-commit at gcc dot gnu.org
2022-03-25 10:23 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103691-4-vu4haWkrAm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).