From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id F06083858D37; Mon, 18 Mar 2024 17:48:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F06083858D37
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1710784100;
	bh=XuY/5F4egiYJIEsOCyfYrlStk3snOocZX9x5unzjbAY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Pbw4GcjC9sjCU2Nz5cx5ep0saaxnTmKB8oN70sm7cDQa5Qs5oD1HhCadHLsBCju4X
	 ytywkGEdfqM5wRzzqjQvlVcUYyFvYVzzIEA6FQjly8Nl9asBldsmTx/9RGE4DO2dlC
	 +PTYRDSP6GJEHlfDigylptSI9RiDseVfm6mhiHqo=
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/103715] [11/12/13/14 Regression] ICE in
 gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe
Date: Mon, 18 Mar 2024 17:48:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: anlauf at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: anlauf at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: assigned_to bug_status cc
Message-ID: <bug-103715-4-xkCOigBiCP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-103715-4@http.gcc.gnu.org/bugzilla/>
References: <bug-103715-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103715

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot g=
nu.org
             Status|NEW                         |ASSIGNED
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
Obvious fix for the invalid read (untested):

diff --git a/gcc/fortran/frontend-passes.cc b/gcc/fortran/frontend-passes.cc
index 06dfa1a3232..3c06018fdbb 100644
--- a/gcc/fortran/frontend-passes.cc
+++ b/gcc/fortran/frontend-passes.cc
@@ -5807,6 +5807,9 @@ check_externals_expr (gfc_expr **ep, int *walk_subtre=
es
ATTRIBUTE_UNUSED,
   if (e->expr_type !=3D EXPR_FUNCTION)
     return 0;

+  if (e->symtree && e->symtree->n.sym->attr.subroutine)
+    return 0;
+
   sym =3D e->value.function.esym;
   if (sym =3D=3D NULL)
     return 0;=