public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103723] zero extend not sunk out of the loop after IV-OPTS in the sink pass
Date: Tue, 04 Jan 2022 11:24:44 +0000	[thread overview]
Message-ID: <bug-103723-4-pFq4kw7TkV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103723-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103723

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|zero extend not moved out   |zero extend not sunk out of
                   |of the loop after IV-OPTS   |the loop after IV-OPTS in
                   |                            |the sink pass

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Note there's pass_sink_code after IVOPTs which is what is designed to perform
sinking.  That is probably confused by seeing

  <bb 5> [local count: 1014686026]:
  # ivtmp.7_15 = PHI <ivtmp.7_7(7), 2(3)>
  _4 = (unsigned int) ivtmp.7_15;
  _3 = MEM[(const uint8_t *)buf_9(D) + ivtmp.7_15 * 1];
  _6 = MEM[(const uint8_t *)buf_back_11(D) + ivtmp.7_15 * 1];
  if (_3 == _6)
    goto <bb 4>; [94.50%]
  else
    goto <bb 10>; [5.50%]

  <bb 10> [local count: 55807731]:

  <bb 6> [local count: 114863531]:
  # len_test_14 = PHI <len_test_12(9), _4(10), 2(8)>
  return len_test_14;

where it doesn't consider inserting on edges because usually the pred works
fine but here it's a no-op sink and splitting the edge might be profitable
because its a loop exit.

So the sinking pass needs tweaking for such case (but _not_ split the edge
in case the PHI use is on a simple merge)

      parent reply	other threads:[~2022-01-04 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15  2:54 [Bug tree-optimization/103723] New: Loop invariant motion pass failed to remove unused code from loop lingling.kong7 at gmail dot com
2021-12-15 11:39 ` [Bug tree-optimization/103723] zero extend not moved out of the loop after IV-OPTS pinskia at gcc dot gnu.org
2021-12-15 11:45 ` pinskia at gcc dot gnu.org
2022-01-04 11:24 ` rguenth at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103723-4-pFq4kw7TkV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).