From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3FF60385840B; Fri, 17 Dec 2021 06:33:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FF60385840B From: "crazylht at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/103750] [i386] GCC schedules KMOV instructions that destroys performance in loop Date: Fri, 17 Dec 2021 06:33:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: missed-optimization, ra X-Bugzilla-Severity: normal X-Bugzilla-Who: crazylht at gmail dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 06:33:38 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103750 --- Comment #4 from Hongtao.liu --- (In reply to Hongtao.liu from comment #3) > (In reply to Hongtao.liu from comment #2) > > Failed here > >=20 > > /* Allow propagations into a loop only for reg-to-reg copies, since > > replacing one register by another shouldn't increase the cost. */ > > struct loop *def_loop =3D def_insn->bb ()->cfg_bb ()->loop_father; > > struct loop *use_loop =3D use->bb ()->cfg_bb ()->loop_father; > > if ((reg_prop_only || def_loop !=3D use_loop) > > && (!reg_single_def_p (dest) || !reg_single_def_p (src))) > > return false; > >=20 > > But def_loop is inner loop of use_loop, it should be ok to propagate fr= om > > inner loop to outer loop. >=20 > Guess def_loop !=3D use_loop used here with assumption that those "invari= ant" > should be sinked into same loop. There seems to be no pass in rtl level to do "sink" stuff.=