[Bug fortran/103777] New: ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[Bug fortran/103777] New: ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

            Bug ID: 103777
           Summary: ICE in gfc_simplify_maskl, at fortran/simplify.c:4918
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Follow-up of pr103610, affects versions down to at least r5 :


$ cat z1.f90
program p
   integer, parameter :: a(999) = 1
   integer, parameter :: b(1) = maskl(shape(a))
end


$ cat z2.f90
program p
   integer, parameter :: a(-9:999) = 1
   integer, parameter :: b(1) = maskl(shape(a))
end


$ gfortran-12-20211219 -c z1.f90
gmp: overflow in mpz type
f951: internal compiler error: Aborted
0xd6d1ff crash_signal
        ../../gcc/toplev.c:322
0x832369 gfc_simplify_maskl(gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.c:4918
0x7b12f6 do_simplify
        ../../gcc/fortran/intrinsic.c:4648
0x7bc2b8 gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.c:4920
0x7a1df9 gfc_simplify_expr(gfc_expr*, int)
        ../../gcc/fortran/expr.c:2219
0x7a294a scalarize_intrinsic_call
        ../../gcc/fortran/expr.c:2486
0x7a1e4d gfc_simplify_expr(gfc_expr*, int)
        ../../gcc/fortran/expr.c:2227
0x7bc46e gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.c:5070
0x81001c resolve_unknown_f
        ../../gcc/fortran/resolve.c:2972
0x81001c resolve_function
        ../../gcc/fortran/resolve.c:3329
0x81001c gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.c:7166
0x7a1344 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.c:3155
0x7a42b0 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.c:3203
0x78e6c4 variable_decl
        ../../gcc/fortran/decl.c:3004
0x78e6c4 gfc_match_data_decl()
        ../../gcc/fortran/decl.c:6297
0x7f86b3 match_word
        ../../gcc/fortran/parse.c:67
0x7f86b3 decode_statement
        ../../gcc/fortran/parse.c:378
0x7fa0fa next_free
        ../../gcc/fortran/parse.c:1397
0x7fa0fa next_statement
        ../../gcc/fortran/parse.c:1629
0x7fb68b parse_spec
        ../../gcc/fortran/parse.c:4168

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---


$ cat z3.f90
program p
   integer, parameter :: a(999) = 1
   integer, parameter :: b(1) = maskr(shape(a))
end


$ cat z4.f90
program p
   integer, parameter :: a(-99:999) = 1
   integer, parameter :: b(1) = maskr(shape(a))
end


$ gfortran-12-20211219 -c z3.f90
f951: internal compiler error: in gfc_convert_mpz_to_signed, at
fortran/simplify.c:193
0x82ac61 gfc_convert_mpz_to_signed(__mpz_struct*, int)
        ../../gcc/fortran/simplify.c:193
0x83225a gfc_simplify_maskr(gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.c:4888
0x7b12f6 do_simplify
        ../../gcc/fortran/intrinsic.c:4648
#...

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
   Last reconfirmed|                            |2021-12-20
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from anlauf at gcc dot gnu.org ---
Reduced testcase:

  print *, maskl([999])
end

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

--- Comment #3 from anlauf at gcc dot gnu.org ---
Minimal fix (for maskl):

diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 90067b6bbe6..45080e8b912 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -4909,6 +4909,9 @@ gfc_simplify_maskl (gfc_expr *i, gfc_expr *kind_arg)
   bool fail = gfc_extract_int (i, &arg);
   gcc_assert (!fail);

+  if (!gfc_check_mask (i, kind_arg))
+    return &gfc_bad_expr;
+
   result = gfc_get_constant_expr (BT_INTEGER, kind, &i->where);

   /* MASKL(n) = 2^bit_size - 2^(bit_size - n) */

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #4 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-December/057215.html

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:49d73c9fb644673323845efebfe6b3106e70af8a

commit r12-6388-g49d73c9fb644673323845efebfe6b3106e70af8a
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Dec 20 22:59:53 2021 +0100

    Fortran: check arguments of MASKL/MASKR intrinsics before simplification

    gcc/fortran/ChangeLog:

            PR fortran/103777
            * simplify.c (gfc_simplify_maskr): Check validity of argument 'I'
            before simplifying.
            (gfc_simplify_maskl): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/103777
            * gfortran.dg/masklr_3.f90: New test.

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed for gcc-12.  Closing.

Thanks for the review!

[Bug fortran/103777] ICE in gfc_simplify_maskl, at fortran/simplify.c:4918

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103777

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3bd2fd2840789909f6088d1c00d2efe9567293b4

commit r11-9462-g3bd2fd2840789909f6088d1c00d2efe9567293b4
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Dec 20 22:59:53 2021 +0100

    Fortran: check arguments of MASKL/MASKR intrinsics before simplification

    gcc/fortran/ChangeLog:

            PR fortran/103777
            * simplify.c (gfc_simplify_maskr): Check validity of argument 'I'
            before simplifying.
            (gfc_simplify_maskl): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/103777
            * gfortran.dg/masklr_3.f90: New test.

    (cherry picked from commit 49d73c9fb644673323845efebfe6b3106e70af8a)