[Bug fortran/103782] New: internal error occurs when overloading intrinsic

[Bug fortran/103782] New: internal error occurs when overloading intrinsic

[urbanjost at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

            Bug ID: 103782
           Summary: internal error occurs when overloading intrinsic
           Product: gcc
           Version: 10.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: urbanjost at comcast dot net
  Target Milestone: ---

program runtest
implicit none
! 
! if overload an intrinsic like dble or real this fails
!
!   internal compiler error: in gfc_trans_array_constructor_subarray, at
fortran/trans-array.c:1876
!   Please submit a full bug report,
!   with preprocessed source if appropriate.
!
! if change name DBLE to SOMETHING it works
!
! works with nvfortran(1) and ifort(1)

interface dble;    procedure to_double;  end interface

write(*,*)dble([10.0d0,20.0d0]) - [10.0d0,20.0d0]
contains

elemental function to_double(valuein) result(d_out)
doubleprecision,intent(in) :: valuein
doubleprecision            :: d_out
    d_out=valuein
end function to_double

end program runtest

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
      Known to work|                            |8.1.0, 8.5.0
             Status|UNCONFIRMED                 |NEW
      Known to fail|                            |9.1.0
   Target Milestone|---                         |9.5
   Last reconfirmed|                            |2021-12-20
     Ever confirmed|0                           |1
            Summary|internal error occurs when  |[9/10/11/12 Regression]
                   |overloading intrinsic       |internal error occurs when
                   |                            |overloading intrinsic

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed, a regression even.

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org
            Summary|[9/10/11/12 Regression]     |[9/10/11/12 Regression]
                   |internal error occurs when  |internal error occurs when
                   |overloading intrinsic       |overloading intrinsic since
                   |                            |r9-1566-g87c789f1c0b2df41

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r9-1566-g87c789f1c0b2df41.

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
The following patch seems to solve this and to regtest ok:

diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c
index 96a2cd70900..6ecd79beef0 100644
--- a/gcc/fortran/expr.c
+++ b/gcc/fortran/expr.c
@@ -2219,7 +2219,7 @@ gfc_simplify_expr (gfc_expr *p, int type)
          && gfc_intrinsic_func_interface (p, 1) == MATCH_ERROR)
        return false;

-      if (p->expr_type == EXPR_FUNCTION)
+      if (p->symtree && (p->value.function.isym || (p->ts.type ==
BT_UNKNOWN)))
        {
          if (p->symtree)
            isym = gfc_find_function (p->symtree->n.sym->name);

@Paul: can you comment on this as original author of that code block?

It appears that the original "if" was not intended as we are already in a

  switch (p->expr_type)
...
    case EXPR_FUNCTION:

Now my interpretation is: we want to do scalarize_intrinsic_call if we either
know already that the function did resolve to an intrinsic, or we have a name
but want to look it up.

(Omitting the latter part regression on gfortran.dg/fmt_nonchar_3.f90)

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #4 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-January/057387.html

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:a4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd

commit r12-6593-ga4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 13 21:50:45 2022 +0100

    Fortran: fix ICE overloading elemental intrinsics

    gcc/fortran/ChangeLog:

            PR fortran/103782
            * expr.c (gfc_simplify_expr): Adjust logic for when to scalarize a
            call of an intrinsic which may have been overloaded.

    gcc/testsuite/ChangeLog:

            PR fortran/103782
            * gfortran.dg/overload_4.f90: New test.

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[urbanjost at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

--- Comment #6 from urbanjost at comcast dot net ---
Thanks for the quick response! Fantastic!

That gets me below a dozen bug reports. I'll have to go break something new :> 

g95/gfortran saved fortran IMHO. Thanks to all the gfortran heroes out there,
past and present.

> On 01/14/2022 1:22 PM cvs-commit at gcc dot gnu.org <gcc-bugzilla@gcc.gnu.org> wrote:
> 
>  
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782
> 
> --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
> The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
> 
> https://gcc.gnu.org/g:a4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd
> 
> commit r12-6593-ga4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd
> Author: Harald Anlauf <anlauf@gmx.de>
> Date:   Thu Jan 13 21:50:45 2022 +0100
> 
>     Fortran: fix ICE overloading elemental intrinsics
> 
>     gcc/fortran/ChangeLog:
> 
>             PR fortran/103782
>             * expr.c (gfc_simplify_expr): Adjust logic for when to scalarize a
>             call of an intrinsic which may have been overloaded.
> 
>     gcc/testsuite/ChangeLog:
> 
>             PR fortran/103782
>             * gfortran.dg/overload_4.f90: New test.
> 
> -- 
> You are receiving this mail because:
> You reported the bug.

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:eff452df296a6f3d0f94408bb2a4a5c4a3c86eb7

commit r11-9466-geff452df296a6f3d0f94408bb2a4a5c4a3c86eb7
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 13 21:50:45 2022 +0100

    Fortran: fix ICE overloading elemental intrinsics

    gcc/fortran/ChangeLog:

            PR fortran/103782
            * expr.c (gfc_simplify_expr): Adjust logic for when to scalarize a
            call of an intrinsic which may have been overloaded.

    gcc/testsuite/ChangeLog:

            PR fortran/103782
            * gfortran.dg/overload_4.f90: New test.

    (cherry picked from commit a4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd)

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:48ef652689b96f4305d5a9c30c4c9f2008cbd4d8

commit r10-10412-g48ef652689b96f4305d5a9c30c4c9f2008cbd4d8
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 13 21:50:45 2022 +0100

    Fortran: fix ICE overloading elemental intrinsics

    gcc/fortran/ChangeLog:

            PR fortran/103782
            * expr.c (gfc_simplify_expr): Adjust logic for when to scalarize a
            call of an intrinsic which may have been overloaded.

    gcc/testsuite/ChangeLog:

            PR fortran/103782
            * gfortran.dg/overload_4.f90: New test.

    (cherry picked from commit a4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd)

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7fecbf36d174c8005e8c5cfb7089c6bd4d0f6a79

commit r9-9923-g7fecbf36d174c8005e8c5cfb7089c6bd4d0f6a79
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 13 21:50:45 2022 +0100

    Fortran: fix ICE overloading elemental intrinsics

    gcc/fortran/ChangeLog:

            PR fortran/103782
            * expr.c (gfc_simplify_expr): Adjust logic for when to scalarize a
            call of an intrinsic which may have been overloaded.

    gcc/testsuite/ChangeLog:

            PR fortran/103782
            * gfortran.dg/overload_4.f90: New test.

    (cherry picked from commit a4a8ae123cd70188e4b4bf5e288a84e0a76fb0fd)

[Bug fortran/103782] [9/10/11/12 Regression] internal error occurs when overloading intrinsic since r9-1566-g87c789f1c0b2df41

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103782

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!