From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A903B3858C3A; Wed, 22 Dec 2021 08:56:21 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A903B3858C3A
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103799] switch expansion could be smarter
Date: Wed, 22 Dec 2021 08:56:21 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: marxin at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: everconfirmed cf_reconfirmed_on bug_status cc
Message-ID: <bug-103799-4-OyyqW4P7FV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-103799-4@http.gcc.gnu.org/bugzilla/>
References: <bug-103799-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Dec 2021 08:56:21 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103799

Martin Li=C5=A1ka <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-12-22
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Li=C5=A1ka <marxin at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #0)
> Take:
> auto f(char c)
> {
>   int t1;
>   switch (c)
>     {
>        case '1':
>          t1 =3D 1;
>          break;
>        case '2':
>          t1 =3D 2;
>          break;
>        case '3':
>          t1 =3D 3;
>          break;
>        case '\0':
>          t1 =3D 4;
>          break;
>        default:
>          t1 =3D -1;
>     }
>    return t1;
> }

Confirmed. Here we have:

  switch (_1) <default: <D.1986>, case 0: <D.1985>, case 49: <D.1982>, case=
 50:
<D.1983>, case 51: <D.1984>>

that's rejected by switch conversion [0, 51] range is quite sparse.

>=20
>=20
> auto f1(char c)
> {
>   int t1;
>   switch (c)
>     {
>        case '1':
>          t1 =3D 1;
>          break;
>        case '2':
>          t1 =3D 2;
>          break;
>        case '3':
>          t1 =3D 3;
>          break;

Here the first part is transformed by switch conversion as:
Linear transformation with A =3D 1 and B =3D -48

>     default:
>       if (c =3D=3D '\0') t1 =3D 4; else t1 =3D -1;

And this is a classical
# t1_2 =3D PHI <4(4), -1(5), t1_5(3)>

So the idea of the transformation is basically to remove cases that "block"
and interesting switch optimization and handle these in default. Smart,
but not easy to achieve :P

>     }
>    return t1;
> }
>=20
> f1 produces better code than f.=