public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/103829] New: [9/10/11/12 Regression] missing shrink wrapping for simple/obvious code Date: Sat, 25 Dec 2021 22:16:17 +0000 [thread overview] Message-ID: <bug-103829-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103829 Bug ID: 103829 Summary: [9/10/11/12 Regression] missing shrink wrapping for simple/obvious code Product: gcc Version: 12.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: normal Priority: P3 Component: rtl-optimization Assignee: unassigned at gcc dot gnu.org Reporter: pinskia at gcc dot gnu.org Target Milestone: --- Target: x86_64-linux-gnu aarch64-linux-gnu Take: extern int _IO_getc (void *) ; extern int *__errno_location (void) __attribute__ ((__const__)); void readError ( void ); typedef struct { void* handle; int buffer; int buffLive; char mode; } BitStream; int bsGetBit ( BitStream* bs ) { if (bs->buffLive > 0) { bs->buffLive --; return ( ((bs->buffer) >> (bs->buffLive)) & 0x1 ); } else { int retVal = _IO_getc (bs->handle); if ( retVal == (-1) ) { if ((*__errno_location ()) != 0) readError(); return 2; } bs->buffLive = 7; bs->buffer = retVal; return ( ((bs->buffer) >> 7) & 0x1 ); } } ----- CUT ---- GCC 4.9.0-8.5.0 was able to shrink wrap the above function. But starting in GCC 9, GCC does not; there is an extra mov using a callee saved register. This happens on both aarch64 and x86_64 So I suspect it was a generic change which caused it.
next reply other threads:[~2021-12-25 22:16 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-25 22:16 pinskia at gcc dot gnu.org [this message] 2021-12-25 22:17 ` [Bug rtl-optimization/103829] " pinskia at gcc dot gnu.org 2022-05-27 9:47 ` [Bug rtl-optimization/103829] [10/11/12/13 " rguenth at gcc dot gnu.org 2022-06-28 10:47 ` jakub at gcc dot gnu.org 2023-04-14 4:53 ` law at gcc dot gnu.org 2023-07-07 10:41 ` [Bug rtl-optimization/103829] [11/12/13/14 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103829-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).