public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug debug/103874] [11/12 Regression] ICE in internal_error on riscv64 and -gsplit-dwarf Date: Thu, 20 Jan 2022 10:59:09 +0000 [thread overview] Message-ID: <bug-103874-4-NOi9E2gWpw@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103874-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103874 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:68f03ac49cb4f585dbce78dc9e4c4a9ec950e83c commit r12-6758-g68f03ac49cb4f585dbce78dc9e4c4a9ec950e83c Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Jan 20 11:58:20 2022 +0100 dwarf2out: Fix -gsplit-dwarf on riscv [PR103874] riscv*-*-* are the only modern targets that !HAVE_AS_LEB128 (apparently due to some aggressive linker optimizations). As the following testcase shows, we mishandle in index_rnglists the !HAVE_AS_LEB128 && !have_multiple_function_sections case. output_rnglists does roughly: FOR_EACH_VEC_SAFE_ELT (ranges_table, i, r) { ... if (block_num > 0) { ... if (HAVE_AS_LEB128) { if (!have_multiple_function_sections) { // code not using r->*_entry continue; } // code that sometimes doesn't use r->*_entry, // sometimes r->begin_entry } else if (dwarf_split_debug_info) { // code that uses both r->begin_entry and r->end_entry } else { // code not using r->*_entry } } else if (block_num < 0) { if (!have_multiple_function_sections) gcc_unreachable (); ... } } and index_rnglists is what sets up those r->{begin,end}_entry members. The code did an early if (!have_multiple_function_sections) continue; which is fine for the HAVE_AS_LEB128 case, because r->*_entry is not used in that case, but not for !HAVE_AS_LEB128 that uses it anyway. 2022-01-20 Jakub Jelinek <jakub@redhat.com> PR debug/103874 * dwarf2out.cc (index_rnglists): For !HAVE_AS_LEB128 and block_num > 0, index entry even if !have_multiple_function_sections. * gcc.dg/debug/dwarf2/pr103874.c: New test.
next prev parent reply other threads:[~2022-01-20 10:59 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-31 12:48 [Bug c/103874] New: [11/12 Regression] ICE in internal_error on riscv64 aurelien at aurel32 dot net 2021-12-31 12:55 ` [Bug c/103874] " aurelien at aurel32 dot net 2021-12-31 15:14 ` [Bug target/103874] " aurelien at aurel32 dot net 2021-12-31 15:15 ` aurelien at aurel32 dot net 2021-12-31 16:26 ` aurelien at aurel32 dot net 2022-01-01 1:05 ` aurelien at aurel32 dot net 2022-01-01 1:23 ` [Bug debug/103874] [11/12 Regression] ICE in internal_error on riscv64 and -gsplit-dwarf pinskia at gcc dot gnu.org 2022-01-04 14:01 ` rguenth at gcc dot gnu.org 2022-01-19 12:42 ` jakub at gcc dot gnu.org 2022-01-20 2:22 ` pinskia at gcc dot gnu.org 2022-01-20 10:59 ` cvs-commit at gcc dot gnu.org [this message] 2022-01-20 10:59 ` [Bug debug/103874] [11 " jakub at gcc dot gnu.org 2022-01-20 22:34 ` aurelien at aurel32 dot net 2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org 2022-01-24 9:28 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103874-4-NOi9E2gWpw@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).