public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/103904] [defect fix] Please backport P2325R3 to 10 and 11
Date: Fri, 11 Feb 2022 20:40:32 +0000	[thread overview]
Message-ID: <bug-103904-4-orOiDnxuYc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103904-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103904

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:3273e704d04a98bcfccdc93c8d07e88f2b032043

commit r11-9561-g3273e704d04a98bcfccdc93c8d07e88f2b032043
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Feb 11 15:39:06 2022 -0500

    libstdc++: Back out some changes from P2325R3 backport [PR103904]

    In the P2325R3 backport r11-9555 the relaxation of the constraints on
    the partial specialization of __box (which is semantically equivalent to
    the primary template, only more space efficient) means some
    specializations of __box will now use the partial specialization instead
    of the primary template, which constitutes an ABI change unsuitable for
    a release branch.  So this patch reverts this constraint change, which
    isn't needed for correctness anyway.

    Similarly, the change to use __non_propagating_cache for the data member
    split_view::_M_current (so that it's always default-initializable) also
    constitutes an unsuitable ABI change.  This patch reverts this change
    too, and instead further constrains split_view's default constructor to
    require that we can default-initialize _M_current.

            PR libstdc++/103904

    libstdc++-v3/ChangeLog:

            * include/std/ranges (__detail::__box): Revert r11-9555 changes
            to the constraints on the partial specialization and the
            now-unnecessary special member functions.
            (__detail::__non_propagating_cache::operator=): Remove
            now-unused overload added by r11-9555.
            (split_view::_OuterIter::__current): Adjust after reverting the
            r11-9555 change to the type of _M_current.
            (split_view::_M_current): Revert r11-9555 change to its type.
            (split_view::split_view): Constrain the default constructor
            further.
            * testsuite/std/ranges/adaptors/detail/copyable_box.cc: Disable
            now-irrelevant test for the r11-9555 changes to the partial
            specialization of __box.

  parent reply	other threads:[~2022-02-11 20:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 15:22 [Bug c++/103904] New: " h2+bugs at fsfe dot org
2022-01-04 15:45 ` [Bug libstdc++/103904] " redi at gcc dot gnu.org
2022-01-04 15:46 ` redi at gcc dot gnu.org
2022-01-04 15:51 ` redi at gcc dot gnu.org
2022-01-04 15:55 ` h2+bugs at fsfe dot org
2022-01-04 16:13 ` redi at gcc dot gnu.org
2022-01-04 17:13 ` h2+bugs at fsfe dot org
2022-01-05  8:42 ` rguenth at gcc dot gnu.org
2022-02-08 15:53 ` h2+bugs at fsfe dot org
2022-02-08 16:30 ` redi at gcc dot gnu.org
2022-02-08 16:54 ` redi at gcc dot gnu.org
2022-02-08 20:58 ` h2+bugs at fsfe dot org
2022-02-11 14:04 ` cvs-commit at gcc dot gnu.org
2022-02-11 14:04 ` cvs-commit at gcc dot gnu.org
2022-02-11 14:04 ` cvs-commit at gcc dot gnu.org
2022-02-11 20:40 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-31 18:39 ` cvs-commit at gcc dot gnu.org
2022-05-31 18:39 ` cvs-commit at gcc dot gnu.org
2022-05-31 18:49 ` ppalka at gcc dot gnu.org
2022-05-31 19:50 ` h2+bugs at fsfe dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103904-4-orOiDnxuYc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).