* [Bug rtl-optimization/103908] gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
@ 2022-01-04 21:51 ` redi at gcc dot gnu.org
2022-01-04 21:54 ` redi at gcc dot gnu.org
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: redi at gcc dot gnu.org @ 2022-01-04 21:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Seems to have been fixed by r258645
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
2022-01-04 21:51 ` [Bug rtl-optimization/103908] " redi at gcc dot gnu.org
@ 2022-01-04 21:54 ` redi at gcc dot gnu.org
2022-01-04 21:55 ` redi at gcc dot gnu.org
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: redi at gcc dot gnu.org @ 2022-01-04 21:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The attached testcase is:
int a, b;
void foo(void)
{
if (a) {
b = 1;
asm goto ("call 0x0\n\t" : : : : next1);
next1:;
} else {
b = 1;
asm goto ("call 0x1\n\t" : : : : next2);
next2:;
}
}
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
2022-01-04 21:51 ` [Bug rtl-optimization/103908] " redi at gcc dot gnu.org
2022-01-04 21:54 ` redi at gcc dot gnu.org
@ 2022-01-04 21:55 ` redi at gcc dot gnu.org
2022-01-04 22:00 ` [Bug rtl-optimization/103908] gcc miscompile asm goto for O1 pinskia at gcc dot gnu.org
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: redi at gcc dot gnu.org @ 2022-01-04 21:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenth at gcc dot gnu.org
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Richi, did your commit really fix it, or just make it go latent?
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (2 preceding siblings ...)
2022-01-04 21:55 ` redi at gcc dot gnu.org
@ 2022-01-04 22:00 ` pinskia at gcc dot gnu.org
2022-01-04 23:01 ` jakub at gcc dot gnu.org
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-04 22:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Summary|gcc 7.5.0 (and earlier) |gcc miscompile asm goto for
|miscompile asm goto in O1 |O1
|on x86-64 |
Last reconfirmed| |2022-01-04
Ever confirmed|0 |1
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #1)
> Seems to have been fixed by r258645
that just makes the problem latent.
You can still reproduce the issue on the trunk with "-O1 -fdisable-tree-cselim
-fno-tree-sink" .
RTL ifcvt does:
starting the processing of deferred insns
ending the processing of deferred insns
df_analyze called
df_worklist_dataflow_doublequeue: n_basic_blocks 6 n_edges 6 count 6 ( 1)
IF-THEN-ELSE-JOIN block found, pass 1, test 2, then 3, else 4, join 5
changing bb of uid 15
from 4 to 2
deleting insn with uid = 16.
deleting block 4
Removing jump 6.
deleting insn with uid = 6.
deleting insn with uid = 9.
deleting insn with uid = 8.
deleting block 3
Merging block 5 into block 2...
changing bb of uid 22
Merged blocks 2 and 5.
Conversion succeeded on pass 1.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (3 preceding siblings ...)
2022-01-04 22:00 ` [Bug rtl-optimization/103908] gcc miscompile asm goto for O1 pinskia at gcc dot gnu.org
@ 2022-01-04 23:01 ` jakub at gcc dot gnu.org
2022-01-06 8:31 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-04 23:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52125
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52125&action=edit
gcc12-pr103908.patch
Untested fix.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (4 preceding siblings ...)
2022-01-04 23:01 ` jakub at gcc dot gnu.org
@ 2022-01-06 8:31 ` cvs-commit at gcc dot gnu.org
2022-01-06 8:32 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-06 8:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:80ad67e2af0620d58d57d0406dc22693cf5b8ca9
commit r12-6278-g80ad67e2af0620d58d57d0406dc22693cf5b8ca9
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Jan 6 09:29:34 2022 +0100
ifcvt: Check for asm goto at the end of then_bb/else_bb in ifcvt [PR103908]
On the following testcase, RTL ifcvt sees then_bb
(note 7 6 8 3 [bb 3] NOTE_INSN_BASIC_BLOCK)
(insn 8 7 9 3 (set (mem/c:SI (symbol_ref:DI ("b") [flags 0x2] <var_decl
0x7fdccf5b0cf0 b>) [1 b+0 S4 A32])
(const_int 1 [0x1])) "pr103908.c":6:7 81 {*movsi_internal}
(nil))
(jump_insn 9 8 13 3 (parallel [
(asm_operands/v ("# insn 1") ("") 0 []
[]
[
(label_ref:DI 21)
] pr103908.c:7)
(clobber (reg:CC 17 flags))
]) "pr103908.c":7:5 -1
(expr_list:REG_UNUSED (reg:CC 17 flags)
(nil))
-> 21)
and similarly else_bb (just with a different asm_operands template).
It checks that those basic blocks have a single successor and
uses last_active_insn which intentionally skips over JUMP_INSNs, sees
both basic blocks contain the same set and merges them (or if the
sets are different, attempts some other noce optimization).
But we can't assume that the jump, even when it has only a single
successor,
has no side-effects.
The following patch fixes it by punting if test_bb ends with a JUMP_INSN
that isn't onlyjump_p.
2022-01-06 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/103908
* ifcvt.c (bb_valid_for_noce_process_p): Punt on bbs ending with
asm goto.
* gcc.target/i386/pr103908.c: New test.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (5 preceding siblings ...)
2022-01-06 8:31 ` cvs-commit at gcc dot gnu.org
@ 2022-01-06 8:32 ` jakub at gcc dot gnu.org
2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-06 8:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (6 preceding siblings ...)
2022-01-06 8:32 ` jakub at gcc dot gnu.org
@ 2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org
2022-01-24 9:29 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-24 9:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:0dd533da49cf15aa9afd35634ba4bd80e9c96565
commit r11-9498-g0dd533da49cf15aa9afd35634ba4bd80e9c96565
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Jan 6 09:29:34 2022 +0100
ifcvt: Check for asm goto at the end of then_bb/else_bb in ifcvt [PR103908]
On the following testcase, RTL ifcvt sees then_bb
(note 7 6 8 3 [bb 3] NOTE_INSN_BASIC_BLOCK)
(insn 8 7 9 3 (set (mem/c:SI (symbol_ref:DI ("b") [flags 0x2] <var_decl
0x7fdccf5b0cf0 b>) [1 b+0 S4 A32])
(const_int 1 [0x1])) "pr103908.c":6:7 81 {*movsi_internal}
(nil))
(jump_insn 9 8 13 3 (parallel [
(asm_operands/v ("# insn 1") ("") 0 []
[]
[
(label_ref:DI 21)
] pr103908.c:7)
(clobber (reg:CC 17 flags))
]) "pr103908.c":7:5 -1
(expr_list:REG_UNUSED (reg:CC 17 flags)
(nil))
-> 21)
and similarly else_bb (just with a different asm_operands template).
It checks that those basic blocks have a single successor and
uses last_active_insn which intentionally skips over JUMP_INSNs, sees
both basic blocks contain the same set and merges them (or if the
sets are different, attempts some other noce optimization).
But we can't assume that the jump, even when it has only a single
successor,
has no side-effects.
The following patch fixes it by punting if test_bb ends with a JUMP_INSN
that isn't onlyjump_p.
2022-01-06 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/103908
* ifcvt.c (bb_valid_for_noce_process_p): Punt on bbs ending with
asm goto.
* gcc.target/i386/pr103908.c: New test.
(cherry picked from commit 80ad67e2af0620d58d57d0406dc22693cf5b8ca9)
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (7 preceding siblings ...)
2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org
@ 2022-01-24 9:29 ` jakub at gcc dot gnu.org
2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-24 9:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.3 too.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (8 preceding siblings ...)
2022-01-24 9:29 ` jakub at gcc dot gnu.org
@ 2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org
2022-05-11 6:23 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-10 8:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:8df8eb6dd5b02d2a5b950a00c09590da423db8cc
commit r10-10664-g8df8eb6dd5b02d2a5b950a00c09590da423db8cc
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Jan 6 09:29:34 2022 +0100
ifcvt: Check for asm goto at the end of then_bb/else_bb in ifcvt [PR103908]
On the following testcase, RTL ifcvt sees then_bb
(note 7 6 8 3 [bb 3] NOTE_INSN_BASIC_BLOCK)
(insn 8 7 9 3 (set (mem/c:SI (symbol_ref:DI ("b") [flags 0x2] <var_decl
0x7fdccf5b0cf0 b>) [1 b+0 S4 A32])
(const_int 1 [0x1])) "pr103908.c":6:7 81 {*movsi_internal}
(nil))
(jump_insn 9 8 13 3 (parallel [
(asm_operands/v ("# insn 1") ("") 0 []
[]
[
(label_ref:DI 21)
] pr103908.c:7)
(clobber (reg:CC 17 flags))
]) "pr103908.c":7:5 -1
(expr_list:REG_UNUSED (reg:CC 17 flags)
(nil))
-> 21)
and similarly else_bb (just with a different asm_operands template).
It checks that those basic blocks have a single successor and
uses last_active_insn which intentionally skips over JUMP_INSNs, sees
both basic blocks contain the same set and merges them (or if the
sets are different, attempts some other noce optimization).
But we can't assume that the jump, even when it has only a single
successor,
has no side-effects.
The following patch fixes it by punting if test_bb ends with a JUMP_INSN
that isn't onlyjump_p.
2022-01-06 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/103908
* ifcvt.c (bb_valid_for_noce_process_p): Punt on bbs ending with
asm goto.
* gcc.target/i386/pr103908.c: New test.
(cherry picked from commit 80ad67e2af0620d58d57d0406dc22693cf5b8ca9)
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (9 preceding siblings ...)
2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org
@ 2022-05-11 6:23 ` cvs-commit at gcc dot gnu.org
2022-05-11 6:36 ` jakub at gcc dot gnu.org
2024-02-14 17:23 ` pinskia at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-11 6:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:e875dc9f975ee0a1f9468fda9ee29533cca77181
commit r9-10117-ge875dc9f975ee0a1f9468fda9ee29533cca77181
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Jan 6 09:29:34 2022 +0100
ifcvt: Check for asm goto at the end of then_bb/else_bb in ifcvt [PR103908]
On the following testcase, RTL ifcvt sees then_bb
(note 7 6 8 3 [bb 3] NOTE_INSN_BASIC_BLOCK)
(insn 8 7 9 3 (set (mem/c:SI (symbol_ref:DI ("b") [flags 0x2] <var_decl
0x7fdccf5b0cf0 b>) [1 b+0 S4 A32])
(const_int 1 [0x1])) "pr103908.c":6:7 81 {*movsi_internal}
(nil))
(jump_insn 9 8 13 3 (parallel [
(asm_operands/v ("# insn 1") ("") 0 []
[]
[
(label_ref:DI 21)
] pr103908.c:7)
(clobber (reg:CC 17 flags))
]) "pr103908.c":7:5 -1
(expr_list:REG_UNUSED (reg:CC 17 flags)
(nil))
-> 21)
and similarly else_bb (just with a different asm_operands template).
It checks that those basic blocks have a single successor and
uses last_active_insn which intentionally skips over JUMP_INSNs, sees
both basic blocks contain the same set and merges them (or if the
sets are different, attempts some other noce optimization).
But we can't assume that the jump, even when it has only a single
successor,
has no side-effects.
The following patch fixes it by punting if test_bb ends with a JUMP_INSN
that isn't onlyjump_p.
2022-01-06 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/103908
* ifcvt.c (bb_valid_for_noce_process_p): Punt on bbs ending with
asm goto.
* gcc.target/i386/pr103908.c: New test.
(cherry picked from commit 80ad67e2af0620d58d57d0406dc22693cf5b8ca9)
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (10 preceding siblings ...)
2022-05-11 6:23 ` cvs-commit at gcc dot gnu.org
@ 2022-05-11 6:36 ` jakub at gcc dot gnu.org
2024-02-14 17:23 ` pinskia at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-05-11 6:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug rtl-optimization/103908] gcc miscompile asm goto for O1
2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com
` (11 preceding siblings ...)
2022-05-11 6:36 ` jakub at gcc dot gnu.org
@ 2024-02-14 17:23 ` pinskia at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-14 17:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail|12.0 |10.3.0, 11.2.0, 9.4.0
Known to work| |10.4.0, 11.3.0, 9.5.0
Target Milestone|--- |9.5
^ permalink raw reply [flat|nested] 14+ messages in thread