public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/103908] gcc miscompile asm goto for O1 Date: Mon, 24 Jan 2022 09:21:08 +0000 [thread overview] Message-ID: <bug-103908-4-m3AXCKsSJg@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103908-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908 --- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-11 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:0dd533da49cf15aa9afd35634ba4bd80e9c96565 commit r11-9498-g0dd533da49cf15aa9afd35634ba4bd80e9c96565 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Jan 6 09:29:34 2022 +0100 ifcvt: Check for asm goto at the end of then_bb/else_bb in ifcvt [PR103908] On the following testcase, RTL ifcvt sees then_bb (note 7 6 8 3 [bb 3] NOTE_INSN_BASIC_BLOCK) (insn 8 7 9 3 (set (mem/c:SI (symbol_ref:DI ("b") [flags 0x2] <var_decl 0x7fdccf5b0cf0 b>) [1 b+0 S4 A32]) (const_int 1 [0x1])) "pr103908.c":6:7 81 {*movsi_internal} (nil)) (jump_insn 9 8 13 3 (parallel [ (asm_operands/v ("# insn 1") ("") 0 [] [] [ (label_ref:DI 21) ] pr103908.c:7) (clobber (reg:CC 17 flags)) ]) "pr103908.c":7:5 -1 (expr_list:REG_UNUSED (reg:CC 17 flags) (nil)) -> 21) and similarly else_bb (just with a different asm_operands template). It checks that those basic blocks have a single successor and uses last_active_insn which intentionally skips over JUMP_INSNs, sees both basic blocks contain the same set and merges them (or if the sets are different, attempts some other noce optimization). But we can't assume that the jump, even when it has only a single successor, has no side-effects. The following patch fixes it by punting if test_bb ends with a JUMP_INSN that isn't onlyjump_p. 2022-01-06 Jakub Jelinek <jakub@redhat.com> PR rtl-optimization/103908 * ifcvt.c (bb_valid_for_noce_process_p): Punt on bbs ending with asm goto. * gcc.target/i386/pr103908.c: New test. (cherry picked from commit 80ad67e2af0620d58d57d0406dc22693cf5b8ca9)
next prev parent reply other threads:[~2022-01-24 9:21 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-04 21:13 [Bug c/103908] New: gcc 7.5.0 (and earlier) miscompile asm goto in O1 on x86-64 mathieu.desnoyers at efficios dot com 2022-01-04 21:51 ` [Bug rtl-optimization/103908] " redi at gcc dot gnu.org 2022-01-04 21:54 ` redi at gcc dot gnu.org 2022-01-04 21:55 ` redi at gcc dot gnu.org 2022-01-04 22:00 ` [Bug rtl-optimization/103908] gcc miscompile asm goto for O1 pinskia at gcc dot gnu.org 2022-01-04 23:01 ` jakub at gcc dot gnu.org 2022-01-06 8:31 ` cvs-commit at gcc dot gnu.org 2022-01-06 8:32 ` jakub at gcc dot gnu.org 2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org [this message] 2022-01-24 9:29 ` jakub at gcc dot gnu.org 2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org 2022-05-11 6:23 ` cvs-commit at gcc dot gnu.org 2022-05-11 6:36 ` jakub at gcc dot gnu.org 2024-02-14 17:23 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103908-4-m3AXCKsSJg@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).