public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/103917] New: libstdc++-v3/src/c++17/fs_path.cc:74: struct passed by value ?
@ 2022-01-05 10:37 dcb314 at hotmail dot com
2022-01-05 11:38 ` [Bug libstdc++/103917] " redi at gcc dot gnu.org
0 siblings, 1 reply; 2+ messages in thread
From: dcb314 at hotmail dot com @ 2022-01-05 10:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103917
Bug ID: 103917
Summary: libstdc++-v3/src/c++17/fs_path.cc:74: struct passed by
value ?
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: dcb314 at hotmail dot com
Target Milestone: ---
cppcheck says:
libstdc++-v3/src/c++17/fs_path.cc:74:28: performance: Function parameter 's'
should be passed by const reference. [passedByValue]
Source code is
_Parser(string_view_type s, size_t o = 0) : input(s), origin(o) { }
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug libstdc++/103917] libstdc++-v3/src/c++17/fs_path.cc:74: struct passed by value ?
2022-01-05 10:37 [Bug libstdc++/103917] New: libstdc++-v3/src/c++17/fs_path.cc:74: struct passed by value ? dcb314 at hotmail dot com
@ 2022-01-05 11:38 ` redi at gcc dot gnu.org
0 siblings, 0 replies; 2+ messages in thread
From: redi at gcc dot gnu.org @ 2022-01-05 11:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103917
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |INVALID
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
cppcheck is wrong.
https://stackoverflow.com/questions/27256377/c-view-types-pass-by-const-or-by-value
https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-05 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 10:37 [Bug libstdc++/103917] New: libstdc++-v3/src/c++17/fs_path.cc:74: struct passed by value ? dcb314 at hotmail dot com
2022-01-05 11:38 ` [Bug libstdc++/103917] " redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).