[Bug other/103935] New: [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[Bug other/103935] New: [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

            Bug ID: 103935
           Summary: [12 regression] g++.dg/vect/slp-pr98855.cc fails after
                    r12-6273
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:c166632bd22d7da66354121502019fc9c92ef07f, r12-6273
make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m64}'
vect.exp=g++.dg/vect/slp-pr98855.cc"
FAIL: g++.dg/vect/slp-pr98855.cc  -std=c++98  scan-tree-dump slp1 "not
vectorized: vectorization is not profitable"
FAIL: g++.dg/vect/slp-pr98855.cc  -std=c++14  scan-tree-dump slp1 "not
vectorized: vectorization is not profitable"
FAIL: g++.dg/vect/slp-pr98855.cc  -std=c++17  scan-tree-dump slp1 "not
vectorized: vectorization is not profitable"
FAIL: g++.dg/vect/slp-pr98855.cc  -std=c++2a  scan-tree-dump slp1 "not
vectorized: vectorization is not profitable"
# of expected passes            8
# of unexpected failures        4

I am only seeing this on power 7 systems so it may be some vector thing not
supported there.  Hrm.  Looks like the failing test case was changed.

commit c166632bd22d7da66354121502019fc9c92ef07f
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Wed Jan 5 23:16:34 2022 +0100

    i386: Introduce V2QImode minmax, abs and uavgv2hi3_ceil [PR103861]

    Add V2QImode minmax, abs and uavxv2qi3_ceil operations with SSE registers.
. . .    
        * g++.dg/vect/slp-pr98855.cc (dg-final): Check that
        no vectorization using SLP was performed.

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
As said in the patch submission:

I have changed scan-tree-dump patterns in g++.dg/vect/slp-pr98855.cc
to check that no SLP vectorization was performed. The existing
scan-tree-dump-times was too fragile, since the message was output for
every vectorization mode.

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Well, it was

// This used to work on { target x86_64-*-* i?86-*-* } but a fix in SLP
// discovery makes us trip over the threshold again.
// { dg-final { scan-tree-dump-times "not vectorized: vectorization is not prof
itable" 2 "slp1" { xfail *-*-* } } }

and it was xfailed, but you changed it to

// { dg-final { scan-tree-dump "not vectorized: vectorization is not profitable
" "slp1" } }
// { dg-final { scan-tree-dump-not "vectorizing stmts using SLP" "slp1" } }

no longer xfailed.  I suggest to re-add the { xfail *-*-* } to the
profitability
check.

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Richard Biener from comment #2)
> no longer xfailed.  I suggest to re-add the { xfail *-*-* } to the
> profitability check.

You mean xfail for non-x86 targets?

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Uroš Bizjak from comment #3)
> (In reply to Richard Biener from comment #2)
> > no longer xfailed.  I suggest to re-add the { xfail *-*-* } to the
> > profitability check.
> 
> You mean xfail for non-x86 targets?

Yes (if it now works consistently on x86 targets)

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:e1503b9a3d2f480d3df42823cd47c3b6c12f5564

commit r12-6534-ge1503b9a3d2f480d3df42823cd47c3b6c12f5564
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Wed Jan 12 20:38:42 2022 +0100

    testsuite: Compile g++.dg/vect/slp-pr98855.cc only for x86 targets
[PR103935]

    The testcase is x86 specific, other targets have different costs defined.

    2022-01-12  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/testsuite/ChangeLog:

            PR target/103935
            * g++.dg/vect/slp-pr98855.cc: Compile only for x86 targets.

[Bug testsuite/103935] [12 regression] g++.dg/vect/slp-pr98855.cc fails after r12-6273

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103935

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.