public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/103939] memset with sizeof in wrong place not detected ?
Date: Fri, 07 Jan 2022 11:27:55 +0000	[thread overview]
Message-ID: <bug-103939-4-0r2meQNXL6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103939-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103939

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-01-07
           Keywords|                            |diagnostic
             Blocks|                            |89863
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The docs explain why GCC's -Wmemset-transposed-args doesn't warn:

  Warn for suspicious calls to the "memset" built-in function where the second
  argument is not zero and the third argument is zero.  For example, the call
  "memset (buf, sizeof buf, 0)" is diagnosed because "memset (buf, 0, sizeof
  buf)" was meant instead.  The diagnostic is only emitted if the third
argument
  is a literal zero.

So not warning for your case is by design.

But it probably makes sense to warn if the second argument is a sizeof
expression, whatever the value of the third argument.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89863
[Bug 89863] [meta-bug] Issues in gcc that other static analyzers (cppcheck,
clang-static-analyzer, PVS-studio) find that gcc misses

  reply	other threads:[~2022-01-07 11:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 11:21 [Bug c++/103939] New: " dcb314 at hotmail dot com
2022-01-07 11:27 ` redi at gcc dot gnu.org [this message]
2022-01-07 13:43 ` [Bug c++/103939] " egallager at gcc dot gnu.org
2022-01-07 14:39 ` redi at gcc dot gnu.org
2022-01-07 14:42 ` redi at gcc dot gnu.org
2022-01-07 16:58 ` dcb314 at hotmail dot com
2022-01-07 17:34 ` redi at gcc dot gnu.org
2022-01-07 17:36 ` redi at gcc dot gnu.org
2022-01-07 17:38 ` jakub at gcc dot gnu.org
2022-01-07 17:54 ` redi at gcc dot gnu.org
2022-01-07 18:07 ` schwab@linux-m68k.org
2022-01-07 18:34 ` dcb314 at hotmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103939-4-0r2meQNXL6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).